Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New entry for CCT C-3 - "Navis_EBR SBE" #128

Closed
vturpin opened this issue Apr 13, 2023 · 7 comments · Fixed by #139
Closed

New entry for CCT C-3 - "Navis_EBR SBE" #128

vturpin opened this issue Apr 13, 2023 · 7 comments · Fixed by #139
Assignees
Milestone

Comments

@vturpin
Copy link

vturpin commented Apr 13, 2023

Initial request

Can we add the following entry to the CCT -C3:

CodeFigureForIXIIXIX CodeFigureForBUFR InstrumentMakeAndType_en EquationCoefficients_a EquationCoefficients_b Status
869 869 NAVIS_EBR, SBE conductivity sensor     Operational

Amendment details

NAVIS_EBR is an operational ocean profiling instrument equipped with SBE temperature sensor.
Both float and sensor passed through the Argo requierments.

Comments

No response

Requestor(s)

Victor Turpin (OceanOPS, Argo Data Management Team) - (@vturpin)
Thierry Carval (Coriolis, Argo Data Management Team) - (@tcarval)
Violeta Paba (BODC, Argo Data Management Team)- (@vpada)

Stakeholder(s)

Argo Steering Team
Argo Data Management Team
Argo Data Assembly Centers
OceanOPS

Publication(s)

Example: Manual on Codes (WMO-No. 306), Volume I.2, Common Code Table C-4

Expected impact of change

LOW

Collaborators

No response

References

No response

Validation

No response

@amilan17 amilan17 added this to Submitted in CCT Amendments via automation Apr 14, 2023
@amilan17 amilan17 added this to the FT2023-2 milestone Apr 24, 2023
@amilan17
Copy link
Member

amilan17 commented May 3, 2023

https://github.com/wmo-im/CCT/wiki/Teleconference.2&3May.2023 notes:

team reviewed quickly and have no objections

@amilan17 amilan17 moved this from Submitted to In discussion in CCT Amendments May 3, 2023
@amilan17 amilan17 moved this from In discussion to In validation in CCT Amendments Jun 5, 2023
@vturpin
Copy link
Author

vturpin commented Jun 6, 2023

NAVIS_EBR, SBE conductivity sensor

@amilan17
Copy link
Member

amilan17 commented Jun 6, 2023

https://github.com/wmo-im/CCT/wiki/Teleconference.6.7.June.2023 notes:
don't need "float serial number..."

amilan17 added a commit that referenced this issue Jul 7, 2023
@amilan17 amilan17 self-assigned this Jul 7, 2023
@amilan17
Copy link
Member

amilan17 commented Jul 7, 2023

@marijanacrepulja can you check this PR? #139

@amilan17 amilan17 linked a pull request Jul 7, 2023 that will close this issue
@marijanacrepulja
Copy link
Contributor

@amilan17 I have checked the PR. All looks good!

@amilan17 amilan17 moved this from In validation to Validated in CCT Amendments Jul 14, 2023
amilan17 added a commit that referenced this issue Jul 19, 2023
…br-sbe

#128 new entry for cct c 3 navis ebr sbe
@amilan17 amilan17 moved this from Validated to Ready for FT approval procedure in CCT Amendments Jul 20, 2023
@SBS-EREHM
Copy link

SBS-EREHM commented Nov 8, 2023

Hi @amilan17 Eric Rehm here from Sea-Bird Scientific. I still don't see that the Initial Request in this issue 869 : NAVIS_EBR has been added to CCT C-3. In the Master branch. Id 869 still shows "Reserved". Initial request was to add:

CodeFigureForIXIIXIX CodeFigureForBUFR InstrumentMakeAndType_en EquationCoefficients_a EquationCoefficients_b Status
869 869 NAVIS_EBR, SBE conductivity sensor     Operational

On the NERC Vocab Server (NVS) side, they are apparently blocked on this before they put it in table NVS Table R08
nvs-vocabs/R08#5

@vturpin
Copy link
Author

vturpin commented Nov 8, 2023

@amilan17
could you tell us when the change will be effective and visible in the https://github.com/wmo-im/CCT/blob/master/C03.csv and https://github.com/wmo-im/CCT/blob/master/xml/C03.xml
I understand that the PR has been approved and assume this is just a matter of the new table to be released. Am I right ?
Thanks.
V.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
CCT Amendments
Ready for FT approval procedure
Development

Successfully merging a pull request may close this issue.

4 participants