Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct units in Code table 4.2 discipline 4 category 4 ? #145

Closed
amilan17 opened this issue Mar 29, 2022 · 5 comments · Fixed by #154
Closed

Correct units in Code table 4.2 discipline 4 category 4 ? #145

amilan17 opened this issue Mar 29, 2022 · 5 comments · Fixed by #154
Assignees
Milestone

Comments

@amilan17
Copy link
Member

amilan17 commented Mar 29, 2022

Summary and purpose

Update the units for Cosmic ray neutron flux in Code table 4.2 to align with the units as defined in WMO OSCAR space. (https://space.oscar.wmo.int/variables/view/cosmic_ray_neutron_flux)

NumberParameterUnits
6Cosmic ray neutron flux/h h-1 

Action proposed

review and verify or fix.

Discussions

Detailed proposal

Details of proposal.

@amilan17 amilan17 added this to Submitted in GRIB2 Amendments via automation Mar 29, 2022
@amilan17 amilan17 self-assigned this Mar 29, 2022
@etoyoda
Copy link
Member

etoyoda commented Mar 29, 2022

I'm not a specialist in this discipline, but the unit "/h" seems to represent hourly count of neutrons using a kind of sensors like https://en.wikipedia.org/wiki/Neutron_monitor . If that is the case, it would be better to correct the name of parameter instead of units. Still I wonder why such a quantity is expressed in GRIB though.

@amilan17 amilan17 added this to the FT2022-2 milestone Apr 4, 2022
@amilan17 amilan17 moved this from Submitted to In discussion in GRIB2 Amendments May 11, 2022
@amilan17
Copy link
Member Author

https://github.com/wmo-im/CCT/wiki/Teleconference-18-and-19.5.2022 notes:

change "/h" to  "h-1"

@amilan17 amilan17 moved this from In discussion to In Validation in GRIB2 Amendments May 18, 2022
@amilan17
Copy link
Member Author

amilan17 added a commit that referenced this issue May 19, 2022
@amilan17
Copy link
Member Author

@marijanacrepulja - branch is updated

@marijanacrepulja
Copy link

@amilan17 thanks! I confirm that the branch is updated. We can move this issue to the validated status.

@marijanacrepulja marijanacrepulja moved this from In Validation to Validated in GRIB2 Amendments May 20, 2022
@amilan17 amilan17 linked a pull request May 31, 2022 that will close this issue
@amilan17 amilan17 moved this from Validated to Ready for FT Approval Procedure in GRIB2 Amendments May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
GRIB2 Amendments
Ready for FT Approval Procedure
Development

Successfully merging a pull request may close this issue.

3 participants