Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify 4.2 Direction of Combined Wind Waves and Swell #22

Closed
tomkralidis opened this issue Apr 20, 2020 · 9 comments
Closed

clarify 4.2 Direction of Combined Wind Waves and Swell #22

tomkralidis opened this issue Apr 20, 2020 · 9 comments
Assignees
Projects
Milestone

Comments

@tomkralidis
Copy link
Contributor

tomkralidis commented Apr 20, 2020

Branch

https://github.com/wmo-im/GRIB2/tree/issue-22

Summary and purpose

We are looking for clarification on https://github.com/wmo-im/GRIB2/blob/master/GRIB2_CodeFlag_4_2_CodeTable_en.csv#L896.

Action proposed

  1. update the parameter description to "Mean Direction of Combined Wind Waves and Swell"
  2. if 1 is not possible add a note to explain that the parameter implies a mean direction?

Discussions

Requirements and purposes of the proposal along with other background information, which could be included in the SUMMARY OF MEETING REPORT.

Detailed proposal

Does 'Direction of Combined Wind Waves and Swell' intend to communicate a mean direction?

@tomkralidis tomkralidis added the question Further information is requested label Apr 20, 2020
@sebvi
Copy link
Contributor

sebvi commented Apr 21, 2020

@tomkralidis : It is indeed a mean direction so I support the idea to rename the parameter "Mean Direction of Combined Wind Waves and Swell"

@efucile efucile removed the question Further information is requested label Apr 21, 2020
@efucile efucile added this to Submitted in GRIB2 (old) Apr 21, 2020
@efucile
Copy link
Member

efucile commented Apr 29, 2020

Do we want to say that the word "combined" refers to a mean? Is it to specify better what we mean for combined. I agree that "combined" doesn't explain how, but I am not sure that Mean clarifies combined in the proposed name. Can we find a better solution and possibly delete combined? However, I think that we need to involve someone from the ocean community before changing this.

@edouardsandrine
Copy link

Thanks a lot for your comment. In fact we would like to know if this parameter represents a mean direction , if it is the case, then we suggest to update the definition from "Direction of combined wind waves and swell" to "Mean direction of combined wind waves and swell". Hope it helps....

@sebvi
Copy link
Contributor

sebvi commented Apr 29, 2020

I have discussed this with our wave expert at ECMWF (Jean) before answering last week. He confirmed to me that the name should indeed be "Mean direction of combined wind waves and swell"

@benoitp-cmc
Copy link

Thanks @sebvi (and Jean), this answers the question. Updating the name to clarify would be desirable and I agree with "Mean direction of combined wind waves and swell".

@efucile "combined" indicates we are looking at the total sea which includes wind waves and all the swells. It is also used for "Significant height of combined wind wave and swell" and "Mean period of combined wind waves and swell".

@efucile efucile moved this from Submitted to In validation in GRIB2 (old) Apr 30, 2020
@efucile efucile added this to the FT-2020-2 milestone May 1, 2020
@chenxiaoxia2019
Copy link
Contributor

@tomkralidis Hi, Tom. A new branch for this issue has been created. The parameter description has been updated to "Mean Direction of Combined Wind Waves and Swell". Could you please check the branch? Thanks.

@tomkralidis
Copy link
Contributor Author

@chenxiaoxia2019 +1 thanks.

@chenxiaoxia2019 chenxiaoxia2019 moved this from In validation to Ready for submission to NFP in GRIB2 (old) Jun 30, 2020
@amilan17
Copy link
Member

SUMMARY: Modify entry 14 in Code Table 4.2, discipline 10, category 0.

@amilan17
Copy link
Member

Approved by FT-2020-2.

@amilan17 amilan17 moved this from Ready for submission to NFP to Operational in GRIB2 (old) Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
GRIB2 (old)
  
Operational
Development

Successfully merging a pull request may close this issue.

7 participants