Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

191 new section 4 templates for advanced surface tiling #211

Merged
merged 17 commits into from
Jul 27, 2023
Merged

191 new section 4 templates for advanced surface tiling #211

merged 17 commits into from
Jul 27, 2023

Conversation

amilan17
Copy link
Member

amilan17
amilan17 commented Jul 13, 2023
View reviewed changes
Copy link
Member Author

@amilan17 amilan17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sebvi there are a couple comments for you to respond to. Others are just notes for editorial changes.

GRIB2_CodeFlag_4_251_CodeTable_en.csv Outdated Show resolved Hide resolved
GRIB2_CodeFlag_4_251_CodeTable_en.csv Outdated Show resolved Hide resolved
GRIB2_CodeFlag_4_251_CodeTable_en.csv Outdated Show resolved Hide resolved
GRIB2_CodeFlag_4_251_CodeTable_en.csv Outdated Show resolved Hide resolved
GRIB2_CodeFlag_4_251_CodeTable_en.csv Outdated Show resolved Hide resolved
GRIB2_Template_4_114_ProductDefinitionTemplate_en.csv Show resolved Hide resolved
GRIB2_Template_4_114_ProductDefinitionTemplate_en.csv Outdated Show resolved Hide resolved
GRIB2_Template_4_114_ProductDefinitionTemplate_en.csv Outdated Show resolved Hide resolved
GRIB2_Template_4_115_ProductDefinitionTemplate_en.csv Outdated Show resolved Hide resolved
GRIB2_Template_4_116_ProductDefinitionTemplate_en.csv Outdated Show resolved Hide resolved
@amilan17 amilan17 linked an issue Jul 13, 2023 that may be closed by this pull request
New section 4 templates for advanced surface tiling #191
Closed
@sebvi
Copy link
Contributor

sebvi commented Jul 14, 2023

I think I have addressed all the issues I could understand

@amilan17
Copy link
Member Author

I think I have addressed all the issues I could understand

Thanks @sebvi -- I will address remaining comments.

@amilan17
Copy link
Member Author

#191 - Branches look good with one question remaining

@amilan17 amilan17 marked this pull request as draft July 27, 2023 10:22
@amilan17 amilan17 marked this pull request as ready for review July 27, 2023 12:17
@amilan17 amilan17 merged commit 23d280e into FT2023-2 Jul 27, 2023
@amilan17 amilan17 deleted the 191-new-section-4-templates-for-advanced-surface-tiling branch July 27, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebvi sebvi sebvi left review comments

@SibylleK SibylleK SibylleK left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New section 4 templates for advanced surface tiling
3 participants
@amilan17 @sebvi @SibylleK