Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editorial changes based on feedback from LSU #230

Merged
merged 8 commits into from
Feb 23, 2024
Merged

Conversation

amilan17
Copy link
Member

No description provided.

@amilan17
Copy link
Member Author

@sebvi The publishing department removed all of the spaces in the Octets for consistency with previous templates. For example, "39 + (ND–1)*4" now looks like "39+(ND–1)*4".

Will you confirm that this is ok?

@amilan17 amilan17 changed the base branch from master to FT2024-1 January 3, 2024 12:37
@amilan17 amilan17 requested a review from sebvi January 8, 2024 15:22
@amilan17
Copy link
Member Author

amilan17 commented Jan 8, 2024

@sebvi I think I got all of them. Can you please do a quick check?

@amilan17 amilan17 changed the title editorial changes based on feedback from lsu editorial changes based on feedback from LSU Jan 10, 2024
@amilan17 amilan17 changed the base branch from FT2024-1 to master January 29, 2024 16:50
@amilan17 amilan17 changed the base branch from master to FT2024-1 February 19, 2024 16:41
@amilan17 amilan17 merged commit b683c3c into FT2024-1 Feb 23, 2024
@amilan17 amilan17 deleted the editorial-lsu branch February 23, 2024 13:30
amilan17 added a commit that referenced this pull request Apr 18, 2024
* Update GRIB2_CodeFlag_4_2_CodeTable_en.csv

updated per #229

* adding entries in code table 4.2 for issue #227 (#232)

* adding entries in code table 4.2 for issue #227

* Update GRIB2_CodeFlag_4_2_CodeTable_en.csv

fix CSV

---------

Co-authored-by: Sebastien Villaume <sebastien.villaume@ecmwf.int>

* Update GRIB2_CodeFlag_4_2_CodeTable_en.csv (#228)

updating per #218

* 222 new ocean and ice parameters in code table 42 discipline 10 1 (#233)

* Update CodeFlag_notes.csv

updating per #222

* Update GRIB2_CodeFlag_4_2_CodeTable_en.csv

updating per #222

* Update GRIB2_CodeFlag_4_5_CodeTable_en.csv

updating per #222

---------

Co-authored-by: Jeff Ator <62722702+jbathegit@users.noreply.github.com>

* 226 new section 4 template for further statistics on probabilities based on focal statistics (#235)

* adding new templates, code tables entries and notes for issue #226

* finishing template 4.123 for issue #225

* Update GRIB2_Template_4_123_ProductDefinitionTemplate_en.csv

fix CSV

* editorial

---------

Co-authored-by: Sebastien Villaume <sebastien.villaume@ecmwf.int>

* 224 new probability templates for large ensemble (#234)

* adding templates 4.119 and 4.120 and corresponding entries in code table 4.0 for issue #224

* adding missing entry in Code table 4.7 for issue #224

* editorial

---------

Co-authored-by: Sebastien Villaume <sebastien.villaume@ecmwf.int>

* 220 code table 42 adding new parameters (#239)

* addingnew entries and note for issue #220

* removing the word -depth- from the new entry 20 and the existing entry 13 in code table 4.2 discipline 1 category 0

* editorial

---------

Co-authored-by: Sebastien Villaume <sebastien.villaume@ecmwf.int>

* editorial changes based on feedback from LSU (#230)

#230 
* editorial changes based on feedback from lsu

* change ' - ' to ' to ' in octets where apppropriate

* change ' - ' to ' to ' in octets where apppropriate

* change ' - ' to ' to ' in octets where apppropriate

* octet formating

* octet formating

* octet formating

* octet formating

* editorial

* 221 encoding of drought indexes as defined by wmo (#237)

* update for proposal #221

* fix typos for #221

* fix typos for #221

* removed word drought from entry in code table 4.10

* editorial

* editorial for note 221b

* Update notes/CodeFlag_notes.csv

* editorial

---------

Co-authored-by: Sebastien Villaume <sebastien.villaume@ecmwf.int>

* 225 new templates for probability forecasts based on focal statistics (#236)

* adding/modifying code tables for issue #225

* adding template 4.121 and 4.122 for issue #225

* Update GRIB2_Template_4_121_ProductDefinitionTemplate_en.csv

* Update GRIB2_Template_4_122_ProductDefinitionTemplate_en.csv

* Update GRIB2_CodeFlag_4_103_CodeTable_en.csv

* Update GRIB2_CodeFlag_4_103_CodeTable_en.csv

* Update GRIB2_CodeFlag_4_2_CodeTable_en.csv

* adding notes for issue #225

* editorial

* Update notes/CodeFlag_notes.csv

* editorial

---------

Co-authored-by: Sebastien Villaume <sebastien.villaume@ecmwf.int>

* 173 updates to facilitate needs in modelling for nuclear protection (#241)

* adding/modifying code tables and templates for issue #173

* adding tables for issue #173

* editorial changes

* fix typo

* Update GRIB2_CodeFlag_4_2_CodeTable_en.csv

* Update GRIB2_CodeFlag_4_2_CodeTable_en.csv

* fix CSV

* editorial

* Update GRIB2_Template_4_124_ProductDefinitionTemplate_en.csv

* add missing content

* remove irrelevant notes

---------

Co-authored-by: Sebastien Villaume <sebastien.villaume@ecmwf.int>

* Update GRIB2_CodeFlag_4_9_CodeTable_en.csv

---------

Co-authored-by: Jeff Ator <62722702+jbathegit@users.noreply.github.com>
Co-authored-by: Sebastien Villaume <sebastien.villaume@ecmwf.int>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants