Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide publication artifacts #34

Closed
tomkralidis opened this issue Mar 13, 2023 · 6 comments · Fixed by #70
Closed

provide publication artifacts #34

tomkralidis opened this issue Mar 13, 2023 · 6 comments · Fixed by #70
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@tomkralidis
Copy link
Collaborator

Currently, we have a GitHub Actions CI that uses pywcmp's bundle workflow to publish a first pass/working level JSON file of all topics.

There are a few issues with this workflow:

Assigning to @antje-s and @josusky; additional help is welcome (cc @wmo-im/tt-wismd)

@tomkralidis tomkralidis added the enhancement New feature or request label Mar 13, 2023
@antje-s
Copy link
Contributor

antje-s commented Mar 15, 2023

When going through csv files exactly, I noticed that so far the mapping between the centres and the respective country is missing.
country.csv includes always centre-id as child value and centre-id.csv does not contain a column with an assignment to a country...

@yhonda21
Copy link

In addition, I wonder how this center ID is linked to the name of RSMCs?

@antje-s
Copy link
Contributor

antje-s commented Mar 15, 2023

...maybe we can call a py-script from the action, which does the merge. A first suggestion for such a merge script I put to a new branch:
https://github.com/wmo-im/wis2-topic-hierarchy/blob/JSON_bundle/merge2json/mergeTopic.py
But so far it contains only a fixed number of levels and can certainly be improved by an experienced programmer.

@amilan17
Copy link
Member

When going through csv files exactly, I noticed that so far the mapping between the centres and the respective country is missing. country.csv includes always centre-id as child value and centre-id.csv does not contain a column with an assignment to a country...

see #39

@tomkralidis
Copy link
Collaborator Author

tomkralidis commented Sep 12, 2023

TT-WISMD 2023-09-12:

  • perhaps CSV files are enough? Do we need to articulate the relationships?

  • one issue is the relationship between country and centre id

  • authoritative vocabulary:

    • codes.wmo.int can be used as the authoritative place for uploads
      • follow similar WMDR workflow for TTL generation and upload
  • For runtime validation/bundle:

    • https://schemas.wmo.int/wth/a/ (CSVs) with the same structure as working area on GitHub
    • zipfile download as well
    • centres can download and build out lookup
      • would be valuable to provide this lookup for centres
        • pywcmp would support lookups
          • needs updating to the above structure (move away from JSON bundle)
  • codes.wmo.int authoritative for browsing

  • schemas.wmo.int provides directory structure/zipfile

  • links to be put forth in the guide (already mentioned in each specification)

ACTIONS:

@tomkralidis tomkralidis added this to the INFCOM-3 milestone Sep 12, 2023
@tomkralidis tomkralidis changed the title provide improved JSON bundle provide publication artifacts Sep 12, 2023
@hhaddouch
Copy link

ET-W2AT Washington 13-15 November 2023
the publication mechanism is agreed, and need to be implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging a pull request may close this issue.

6 participants