publish to leaf topics only (#137) #146
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomkralidis
requested review from
gaubert,
amilan17,
solson-nws,
josusky,
davidpodeur,
jsieland,
antje-s,
Amienshxq and
masato-f29
josusky
approved these changes
Jun 3, 2024
amilan17
reviewed
Jun 3, 2024
|
@efucile is this suitable for fast track? this is the addition of new practices (SHALL) and not just code table entries. Previously used valid topics will become invalid. |
| @@ -5,4 +5,6 @@ | |||
| ^|A |Data SHALL NOT be published with a topic that is not defined in this specification. | |||
| ^|B |Data SHALL be published to at least the level of the sub-discipline topic (level 8 or beyond). | |||
| ^|C |Metadata SHALL be published to at least the level of the notification type (``metadata``). | |||
| ^|D |Topics SHALL be published to the lowest possible defined level (leaf). | |||
| ^|E |Topics SHALL NOT be published to intermediary levels where sublevels are defined. | |||
There was a problem hiding this comment.
Rows 8 and 9 are new standard practices / provisions that will lead to previously valid topics becoming invalid. I'm not sure this is suitable for the FT process.
amilan17
requested changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #137
I've also renamed the "Publishing guidelines" section to just "Publishing" (i.e. requirements != guidelines).