Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MessageID generation not random enough #74

Closed
wneessen opened this issue Oct 26, 2022 · 0 comments · Fixed by #75
Closed

MessageID generation not random enough #74

wneessen opened this issue Oct 26, 2022 · 0 comments · Fixed by #75
Assignees
Labels
bug Something isn't working fix-in-progress

Comments

@wneessen
Copy link
Owner

Description

When in a bulk mailing, a list of *mail.Msg is prepared with a message ID in a loop, the processing might be so fast, that the message ID for the message IDs is not random. This might cause issues if mails are delivered to the same person on the same server with one address being forward to the 2nd mail address. Most mail server would "combine" this into one mail. While this might be the wanted behaviour from a mail receiving perspective, from a sending perspectice this is not right. The message ID needs to be unique.

This needs some further investigation.

To Reproduce

This came up in the mail example for discussion: #73

Expected behaviour

A unique and random message id is to be generated for every message.

Screenshots

No response

Attempted Fixes

No response

Additional context

No response

@wneessen wneessen added the bug Something isn't working label Oct 26, 2022
@wneessen wneessen self-assigned this Oct 26, 2022
wneessen added a commit that referenced this issue Oct 26, 2022
This fix makes sure that generated message IDs via SetMessageID() are truly random and unique
@wneessen wneessen linked a pull request Oct 26, 2022 that will close this issue
wneessen added a commit that referenced this issue Oct 26, 2022
The new messageID generated with #74 is a bit too long by default. Th…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fix-in-progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant