Fixed SetMessageID message ID generation #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wneessen
added
hacktoberfest
Codecov Report
@@ Coverage Diff @@
## main #75 +/- ##
=======================================
Coverage 84.58% 84.58%
=======================================
Files 12 12
Lines 1330 1330
=======================================
Hits 1125 1125
Misses 141 141
Partials 64 64
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…. This fix improves it
Since the Windows tests were still failing, we are replacing the random number generation with math/rand with random string generation via crypto/rand
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #74. It makes sure that generated message IDs via SetMessageID() are truly random and unique