Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose AccessKey encode/decode api #296

Merged
merged 2 commits into from
Jul 5, 2023

Conversation

Gozala
Copy link
Contributor

@Gozala Gozala commented Jul 1, 2023

Summary

Fixes #294

This PR fixes/implements the following bugs/features

  • Bug 1
  • Bug 2
  • Feature 1
  • Feature 2
  • Breaking changes

Adds ability to serialize access-key so it can be preserved across sessions

Test plan (required)

Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI.

Added a test to verify changes work

Closing issues

Fixes #294

After Merge

  • Does this change invalidate any docs or tutorials? If so ensure the changes needed are either made or recorded
  • Does this change require a release to be made? Is so please create and deploy the release

@Gozala Gozala requested a review from a team as a code owner July 1, 2023 03:12
@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #296 (d67ddd0) into main (25c5215) will decrease coverage by 0.10%.
The diff coverage is 0.00%.

❗ Current head d67ddd0 differs from pull request most recent head 312cc0b. Consider uploading reports for the commit 312cc0b to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #296      +/-   ##
==========================================
- Coverage   61.47%   61.37%   -0.10%     
==========================================
  Files          40       40              
  Lines        2707     2711       +4     
  Branches      679      679              
==========================================
  Hits         1664     1664              
- Misses        571      575       +4     
  Partials      472      472              
Impacted Files Coverage Δ
wnfs/src/private/keys/access.rs 47.05% <0.00%> (-6.28%) ⬇️

Copy link
Member

@matheus23 matheus23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beat me to it! Thank you very much!

@matheus23 matheus23 merged commit 982feff into wnfs-wg:main Jul 5, 2023
8 checks passed
@github-actions github-actions bot mentioned this pull request Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wasm bindings: Expose AccessKey de/serialization
2 participants