Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll detection strategy does not work within a shadow root #127

Closed
mupchrch opened this issue Jan 15, 2021 · 3 comments
Closed

Scroll detection strategy does not work within a shadow root #127

mupchrch opened this issue Jan 15, 2021 · 3 comments

Comments

@mupchrch
Copy link
Contributor

This line doesn't account for the situation where the element resides within a shadow root. Debug is reporting the element is detached.

I think a check like element.getRootNode().contains(element) could be added here to account for this issue? Not sure which browsers you are targeting to support - might be important to note getRootNode is not supported in IE.

@wnr
Copy link
Owner

wnr commented Jan 20, 2021

@mupchrch Interesting! Yeah, this lib is targeting IE6 😓 . But we could probably just check if getRooNode exists and consider it a new feature upgrade if it does. Would you like to create a PR for this? :)

mupchrch added a commit to mupchrch/element-resize-detector that referenced this issue Jan 20, 2021
mupchrch added a commit to mupchrch/element-resize-detector that referenced this issue Feb 19, 2021
@wnr wnr closed this as completed Feb 20, 2021
@mupchrch
Copy link
Contributor Author

@wnr Not to be a bother.. When can we expect to see v1.2.2 released on npm?

@wnr
Copy link
Owner

wnr commented Feb 26, 2021

@mupchrch Sorry 'bout that! It's now published. Thank you for reminding me :) Have a great weekend!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants