Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setup.py: Allow colorlog 4 #257

Merged
merged 1 commit into from
Oct 15, 2019
Merged

setup.py: Allow colorlog 4 #257

merged 1 commit into from
Oct 15, 2019

Conversation

jayvdb
Copy link
Contributor

@jayvdb jayvdb commented Oct 15, 2019

No description provided.

dhermes
dhermes approved these changes Oct 15, 2019
View reviewed changes
Copy link
Collaborator

@dhermes dhermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I'm unsure if there is any breakage? As long as the tests ran with colorlog 4, this seems fine

@jayvdb
Copy link
Contributor Author

jayvdb commented Oct 15, 2019

I've packaged this up for openSUSE Tumbleweed, which is using colorlog 5, and the tests pass https://build.opensuse.org/package/show/home:jayvdb:branches:devel:languages:python/python-nox

@jayvdb
Copy link
Contributor Author

jayvdb commented Oct 15, 2019

The Appveyor breakage looks unrelated - a bug in pip/conda/etc on Python 3.5.

@jayvdb
Copy link
Contributor Author

jayvdb commented Oct 15, 2019

Hmm. Problem is also occurring on Windows py37 #258

@jayvdb
Copy link
Contributor Author

jayvdb commented Oct 15, 2019

@dhermes , no breakage here ;-)

@theacodes
Copy link
Collaborator

Rad, thanks for doing this and thank you @dhermes for taking a look. :)

@theacodes theacodes merged commit 98a69f4 into wntrblm:master Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhermes dhermes dhermes approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jayvdb @theacodes @dhermes