Add Session.run_always().
#331
Conversation
| external=True, | ||
| ) | ||
| session.install(".") | ||
| ... |
|
lint seems unhappy but otherwise this looks good. Feel free to merge once you've pleased the lint god. |
I noticed this during local dev! Couldn't tell if it was an update to Do you have a "only update formatting if file has been edited" policy? Either way I'll make the updates. |
|
I just ran |
|
Cool. :)
…On Mon, Jun 8, 2020 at 10:10 AM Danny Hermes ***@***.***> wrote:
I just ran nox -s blacken and it touched 6 files, so I made it into #332
<#332>. Will rebase this PR on top
of master once that PR is merged and hopefully the changes will be
smaller.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#331 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAB5I43HACDKKJSOOQ4LBXLRVULR5ANCNFSM4NXV2PCA>
.
|
|
@theacodes This has been rebased and a |
|
Yay!
…On Mon, Jun 8, 2020 at 10:19 AM Danny Hermes ***@***.***> wrote:
@theacodes <https://github.com/theacodes> This has been rebased and a nox
-s blacken commit was added at the end, will merge on green!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#331 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAB5I4YRNICIQZMR4CHE34DRVUMSZANCNFSM4NXV2PCA>
.
|
| "-B", build_dir, | ||
| external=True, | ||
| ) | ||
| session.run_always( |
There was a problem hiding this comment.
Why is this called run_always?
There was a problem hiding this comment.
I feel like we nailed it with the docstring: https://nox.thea.codes/en/stable/config.html#nox.sessions.Session.run_always
Run a command always.
This is a variant of
run()that runs in all cases, including in the presence of--install-only.
There was a problem hiding this comment.
How about session.custom_install_command(...) ?
Seems to be much closer to the intention.
I was now even aware of --install-only.
Fixes #330.