469 add initial cwd to session properties

[franekmagiera]

Closes #469

Added a working directory nox was originaly invoked from to session propreties.

@DiddiLeija I started working on this issue some time ago, but then had a long break and couldn't find time to finalize it until today and now noticed that you already opened a PR for it. Hopefully we did not duplicate much work, sorry for not mentioning it earlier and please let me know if you are ok with me continuing on this one.

[DiddiLeija]

Oh, it's ok. I'll work on another issue. Go ahead!

[theacodes]

This looks great, and thanks for doing it @franekmagiera. :)

I don't love the name original_wd though. :/ I couldn't really find a lot of prior art for this term, but I think either session.executed_from or session.execution_dir might work a bit better. What do you think?

[henryiii]

To me, session.execution_dir sounds like the place it is executing, not the place it was called from. How about session.invocation_dir? I like it ending in dir vs. wd.

[franekmagiera]

@theacodes Thanks!

Now that you mention it I agree original_wd does not make much sense without the context of #469.

I like your propositions, having the name end with dir is better I think. How about just session.starting_dir? It's a bit simpler, but I'm fine with session.invocation_dir as well.

[theacodes]

invocation_dir sounds good to me.

…

On Thu, Sep 9, 2021 at 5:05 PM Franek Magiera ***@***.***> wrote: @theacodes <https://github.com/theacodes> Thanks! Now that you mention it I agree original_wd does not make much sense without the context of #469 <#469>. I like your propositions, having the name end with dir is better I think. How about just session.starting_dir? It's a bit simpler, but I'm fine with session.invocation_dir as well. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#472 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAB5I44SF6XWL3AAD5K4SWTUBEORPANCNFSM5DMQNSAA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[FollowTheProcess]

How about invoked_from? I know it doesn't specify dir explicitly but I think it's nice and clear, especially when in the context of session.invoked_from

[theacodes]

👍

…

On Thu, Sep 9, 2021 at 5:19 PM Tom ***@***.***> wrote: How about invoked_from? I know it doesn't specify dir explicitly but I think it's nice and clear, especially when in the context of session.invoked_from — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#472 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAB5I4YD6GDOEFIHP6TYOJDUBEQFXANCNFSM5DMQNSAA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[henryiii]

I'm okay with that too. It's a tossup for me, I like that the type is in the name with invocation_dir, but invoked_from probably can't be viewed as anything but a directory, and is a bit easier to read.

[franekmagiera]

Ok, session.invoked_from it is then! Thanks for the discussion, I will make necessary changes tomorrow or on Saturday

[franekmagiera]

@theacodes @henryiii @FollowTheProcess Changed the name to invoked_from and merged with main.

[FollowTheProcess]

Looks good to me! happy to merge in unless anyone has any other suggestions/comments? @theacodes @cjolowicz

[theacodes]

I have one plumbing change I want to make here. Let me do that and I'll merge. :)

[theacodes]

Thanks, everyone!