[refactor] Renaming, private methods, method movements

wnuqui · Jan 30, 2021 · b1c329b · b1c329b
1 parent fbe09b5
commit b1c329b
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 16 deletions.
diff --git a/lib/runtime_profiler.rb b/lib/runtime_profiler.rb
@@ -1,7 +1,6 @@
 require 'active_support'
 
 require 'runtime_profiler/profiler'
-require 'method_meter'
 
 module RuntimeProfiler
   include ActiveSupport::Configurable
@@ -40,14 +39,10 @@ def configure
       yield self if block_given?
     end
 
-    def profile!(key, konstants)
-      konstants = konstants.is_a?(Array) ? konstants : [konstants]
-      profiler = Profiler.new(konstants)
-      profiler.prepare_for_profiling
-
-      MethodMeter.measure!(key) { yield }
-
-      profiler.save_profiling_data
+    def profile!(key, constants)
+      constants = constants.is_a?(Array) ? constants : [constants]
+      profiler = Profiler.new(constants)
+      profiler.profile!(key) { yield }
     end
   end
 end
diff --git a/lib/runtime_profiler/profiler.rb b/lib/runtime_profiler/profiler.rb
@@ -1,4 +1,4 @@
-# require 'method_profiler'
+require 'method_meter'
 
 require 'runtime_profiler/callbacks/active_record'
 require 'runtime_profiler/callbacks/action_controller'
@@ -10,14 +10,22 @@ class Profiler
 
     def initialize(constants)
       self.profiled_constants = constants
+      prepare_for_profiling
     end
 
+    def profile!(key)
+      MethodMeter.measure!(key) { yield }
+      save_profiling_data
+    end
+
+    private
+
     def prepare_for_profiling
-      subscribe_to_event_notifications
+      subscribe_to_rails_event_notifications
       prepare_methods_to_profile
     end
 
-    def subscribe_to_event_notifications
+    def subscribe_to_rails_event_notifications
       @subscribers = []
 
       @active_record_callback = Callback::ActiveRecord.new
@@ -31,19 +39,20 @@ def subscribe_to_event_notifications
                       .subscribe('process_action.action_controller', @action_controller_callback)
     end
 
-    def unsubscribe_to_event_notifications
+    def unsubscribe_to_rails_event_notifications
       @subscribers.each do |subscriber|
         ActiveSupport::Notifications.unsubscribe(subscriber)
       end
     end
 
     def prepare_methods_to_profile
-      profiled_constants.flatten
-                            .each { |constant| MethodMeter.observe(constant, RuntimeProfiler.excepted_methods) }
+      profiled_constants
+        .flatten
+        .each { |constant| MethodMeter.observe(constant, RuntimeProfiler.excepted_methods) }
     end
 
     def save_profiling_data
-      unsubscribe_to_event_notifications
+      unsubscribe_to_rails_event_notifications
 
       profiling_data = RuntimeProfiler::Data.new \
         controller_data: @action_controller_callback.controller_data,