[FIX][PERSISTENCE] Fixed an error with 'false' as default

woahdae · Dec 1, 2011 · 12cea4b · 12cea4b
1 parent 32bf8d3
commit 12cea4b
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/lib/tire/model/persistence/attributes.rb b/lib/tire/model/persistence/attributes.rb
@@ -45,7 +45,7 @@ def property(name, options = {})
             define_attribute_methods [name.to_sym]
 
             # Save property default value (when relevant):
-            if default_value = options.delete(:default)
+            unless (default_value = options.delete(:default)).nil?
               property_defaults[name.to_sym] = default_value
             end
 

diff --git a/test/models/persistent_article_with_defaults.rb b/test/models/persistent_article_with_defaults.rb
@@ -4,6 +4,7 @@ class PersistentArticleWithDefaults
 
   property :title
   property :published_on
-  property :tags, :default => []
+  property :tags,   :default => []
+  property :hidden, :default => false
 
 end
diff --git a/test/unit/model_persistence_test.rb b/test/unit/model_persistence_test.rb
@@ -197,7 +197,8 @@ class << a
 
           should "return default value for attribute" do
             article = PersistentArticleWithDefaults.new :title => 'Test'
-            assert_equal [], article.tags
+            assert_equal [],    article.tags
+            assert_equal false, article.hidden
           end
 
           should "have query method for attribute" do