Add local backups support for backup-delete command. #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactoring backup-delete command to add functionality to delete local backups. Add parallel-process flag for backup-delete command.
Switch for non public method for deleter interface.
woblerr
added
documentation
Starting from 25.05.2024, all Greenplum repositories (including gpbackup-s3-plugin) were transferred to the archive on GitHub. At the same time, all tags have been deleted from the archives. Switched to my fork for testing.
Add updates for history file when some errors occurred. Previously, the status did not change when an error occurred. Remove debug message.
Add --ignore-errors flag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added local backups support for
backup-deletecommand.Added
--backup-dir,--parallel-processand--ignore-errorsflags forbackup-deletecommand.For local backups the following logic are applied:
--backup-diroption is specified, the deletion will be performed in provided path.--backup-diroption is not specified, but the backup was made with --backup-dir flag for gpbackup, the deletion will be performed in the backup manifest path.--backup-diroption is not specified and backup directory is not specified in backup manifest, the deletion will be performed in backup folder in the master and segments data directories.For non local backups the following logic are applied:
--plugin-configoption is specified, the deletion will be performed using the storage plugin.Updated e2e tests with
gpbackup-s3-plugin. Starting from 25.05.2024, all Greenplum repositories (including gpbackup-s3-plugin) were transferred to the archive on GitHub. At the same time, all tags have been deleted from the archives. Switched to my fork for testing.Added update mechanism for history file when some errors occurred. Previously, the status did not change when an error occurred.