Fix gpbackup_backup_since_last_completion_seconds metric. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It wasn't taken into account that end time already contains a timezone. With a high probability, the exporter will work in the same timezone as Greenplum cluster. If this isn't the case, then there are many questions about the backup process.
Update the entrypoint in the image to be able to specify timezone when launching the container.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It wasn't taken into account that endtime already contains a timezone. Therefore, the
gpbackup_backup_since_last_completion_secondsmetric showed incorrect values if the Greenplum cluster works not in UTC timezone.With a high probability, the exporter will work in the same timezone as Greenplum cluster. Added accounting for the local timezone when parsing the endtime value.
When running exporter in docker, it is necessary to specify correct timezone via
TZvariable.