Error out when we detect incompatibilities between mingw and msvc #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has caused lots of frustrations: eg: slint-ui/slint#3802 slint-ui/slint#3539 slint-ui/slint#3739
tronical
approved these changes
Nov 2, 2023
Comment on lines
+216
to
+220
| let spec = qmake_query("QMAKE_SPEC"); | ||
| if (spec.contains("msvc") && cargo_target_env == "gnu") | ||
| || (spec.contains("g++") && cargo_target_env == "msvc") | ||
| { | ||
| report_error(&format!("Rust target '{}' is not compatible with Qt mkspec '{spec}'. Mixing MinGW and MSVC is not allowed.", std::env::var_os("TARGET").unwrap_or_default().to_string_lossy())); |
There was a problem hiding this comment.
If you want to make it even more useful to users, I suggest to split this into two if statements, each of which can report in report_error() what the user can do as remedy, i.e. if spec is mdvc but cargo target env is "gnu": "To fix this, please install Qt compiled for MinGW", and for the other one "To fix this, please install Qt for MSVC".
There was a problem hiding this comment.
I believe this is sufficiently clear. They could either solve it by installing a different version of Qt, or getting another build of rust.
(Note that rust users of Slint won't see this error anyway as the warning from the build.rs are hidden.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has caused lots of frustrations: eg:
slint-ui/slint#3802
slint-ui/slint#3539
slint-ui/slint#3739