Flatten component support #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…flattenComponent option will flatten all WOComponent (and EOModeld) resources from Resouces and Components folders into the applications Resources folder. But in contrast to flattenResources it will leave all other folders intact.
|
I am very interested in this. Has anyone had a chance to try it out? @hprange perhaps? I notice it fails in CI, but that seems to be a failure very early in the build. |
|
I've just tried this out and it works perfectly. Nice feature Ralf! Flattens subdirs in @hprange: have you had a chance to try it? I would love to merge this in and get using it, but it would be great to have more than two users vouching for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a new option "flattenComponent". The option is similar to flattenResources, but will leave non WOComponent/EOModeld folder hierarchies intact. The resulting folder structure should be very similar to the one produced by WOLips.
Reason for this change: I have a project with many components, organised in subfolders of the Components folders. Those components must get flattened into to application Resources to be useful. But I have also a folder hierarchy in Resources and WebServerResourced, that should be copied as they are. While flattenResources will either flatten all those components and files or none, this new option flattens only components.
There is also a little bit of code cleanup, mostly warning from the compiler.