Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERXStaticResourceRequestHandler wodata ignored in enviroment with customized WOAdaptorURL #999

Closed
xplants opened this issue Nov 17, 2022 · 2 comments

Comments

@xplants
Copy link
Contributor

xplants commented Nov 17, 2022

When a static resources, from a jar, is accessed in an environment with a custom adaptorUrl that do not start with "/cgi-bin" the wodata parameter from request is ignored and the resource is not served.

A possibile solution

In ERXStaticResourceRequestHandler.java the handleRequest method the uri variable should be evaluated against application.cgiAdaptorURL() instead of the static string /cgi-bin

@xplants xplants changed the title ERXStaticResourceRequestHandler wodata ignored in enviroment with customized adaptorUrl ERXStaticResourceRequestHandler wodata ignored in enviroment with customized WOAdaptorURL Nov 17, 2022
@sal-bock
Copy link

I wonder why the first part of the uri should be evaluated at all. It should be sufficient to check, that wodata is provided as GET parameter.

But if the check is necessary, then the uri variable should be evaluated against request.applicationURLPrefix().
In fact, this method is used in WOResourceManager. urlForResourceNamed to generate the url. The static resources will be loaded from the jar, even if there is a proxy server is part of the game.

@paulhoadley
Copy link
Contributor

PR merged—thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants