ERXExistsQualifier Improvements #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he select statement but should have only replaced once. Without this fix, we cannot reliably chain ExistsQualifiers. Signed-off-by: Aaron Rosenzweig <aaron@chatnbike.com> Conflicts: Frameworks/Core/ERExtensions/Sources/er/extensions/eof/qualifiers/ERXExistsQualifier.java
…stgressql. When trying able alias declarations for t4 and t8, it would also match variable bindings for that had a datatype of int4 and int8 e.g., “?::int8” and “?::int4”
…Qualifier_ReplaceOnce Conflicts: Frameworks/Core/ERExtensions/Sources/er/extensions/eof/qualifiers/ERXExistsQualifier.java
|
I manually merged wocommunity/master into the branch, so now the pull request can be automatically merged. |
|
Is there any issue or questions on this pull request? It's been around for quite a while and it was a pull request on the integration branch as well, before that was dropped. We use it constantly with both FrontBase and PostgreSQL and it is incredibly useful. I don't believe the current ERXExistsQualifier in master can even be used in DB fetches - this is a huge improvement! |
|
I haven't looked at the code, Dave, but what's faf0976 doing in this pull request? Can it be re-done without that huge merge commit? |
ishimoto
added a commit
that referenced
this pull request
Apr 12, 2014
looks great after WOWODC presentation, and quick check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various improvements to ERXExistsQualifier including the ability to make it produce an "in" clause instead of an "exists" clause. The ability to pass a long keyPath into the Qualifier. Fixed various bugs in string replacements with complex joins and also issues noticed in Postgres string replacement of “int4” and “int8"
This is a re-submission of pull request #525 because somehow I had made a branch on WOCommunity and the pull request was tied to that. I've deleted that branch and I am resubmitting the request from the correct repos.