Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mod Security Build Updates #14

Merged
merged 8 commits into from
Dec 17, 2018
Merged

Mod Security Build Updates #14

merged 8 commits into from
Dec 17, 2018

Conversation

allupaku
Copy link
Contributor

I have tested it with all functionalities. It will run with the .so added by this step

runDeps="$( \
, this will find all the run time dependency so files, basically geoip and libmandb.

I have also disabled the mod security by default - as to not break any existing installations, because mod security at times will behave wierd and will start blocking requests. So for such cases where there are lot of false positives i have added env to add more Modsec configurations and to fine tune the thresholds.

I have also added some tests for basic mod sec functionality testing.

@allupaku allupaku mentioned this pull request Dec 13, 2018
@csandanov
Copy link
Member

Thank you, looking better, having tests is especially good. If we're to keep it disabled by default I think we should rename the env var to $NGINX_MODSECURITY_ENABLE to avoid any confusions, that's what we do usually for all images.

Could you please perhaps provide an example where it "acts weird" by blocking requests? I'm sceptical about having a module with the default configuration that breaks something and there's no clear understanding why and how to configure it correctly.

@allupaku
Copy link
Contributor Author

By wierd, i mean not about the modsecurity as such , but the owasp rule set is very strict at default levels that it even blocks a password entry with characters like "!@#" etc. So this need to be fine tuned when using owasp rule set. The lib modsecurity will not break any functionality, but the rules for firewall need to be configured and if we use owasp crs blindly, it will start blocking some legit drupal requests as well.

@csandanov csandanov merged commit 610bfa7 into wodby:master Dec 17, 2018
csandanov added a commit that referenced this pull request Dec 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants