Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
first of all, this is a totally awesome project! I also run my pbs on an Armbian64 system 😄.
Thanks for the build script and patches 🥳.
What I have changed:
debootstrap --variant=buildd bullseye ${CHROOTDIR} http://deb.debian.org/debian/
) I observed that the following packages are also needed:libpam0g-dev
byproxmox-backup
libcurl4-openssl-dev
bypve-xtermjs
/
after each pathproxmox-acme
, see comment)XXX_VER
for the version (I'm also not sure what your intention was, hopefully that was your intention. But I thinkXXX_VERSION
would also look good or even better, what do you think?)sources
(I was not sure what's betterbuild
orsources
, what do you think?)cd <project>
andcd ..
could also be replaced bycd ${SOURCES}/<project>
andcd ${SOURCES}
or/and replacecd
withpushd
/popd
... I was not sure for now I think it is ok as it is.Feedback is welcome!
I will integrate everything you think should be changed or is not good, just let me know.