Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document room:Update() #180

Closed
Zamiell opened this issue Aug 20, 2021 · 1 comment
Closed

Document room:Update() #180

Zamiell opened this issue Aug 20, 2021 · 1 comment

Comments

@Zamiell
Copy link
Collaborator

Zamiell commented Aug 20, 2021

In the docs, it says that room:Update() is useless, but it isn't useless.

  • Take the case of spawning a trapdoor where a pit already exists.
  • If you simply remove the pit and try to spawn a trapdoor, the pit will be successfully removed, but the trapdoor will not appear.
  • The solution is to remove the pit, call room:Update(), and then spawn the trapdoor.

Thus, I think that the docs should recommend that it is best practice to always call room:Update() after removing any grid entity. This recommendation should appear on both the section for room:Update() and room:RemoveGridEntity().

Separately, please link to this issue in the documentation for room:Update().

@wofsauge
Copy link
Owner

Updated infos in 7dc6909

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants