Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scrolling trouble when working with non-zero drum bank #34

Closed
Wohlstand opened this issue Aug 20, 2018 · 7 comments
Closed

Scrolling trouble when working with non-zero drum bank #34

Wohlstand opened this issue Aug 20, 2018 · 7 comments
Assignees
@Wohlstand @jpcima
Labels
bug

Comments

@Wohlstand
Copy link
Owner

When choosing non-zero percussion bank, any attempt to choose instrument in the list drops the scroll down after little moment

peek 2018-08-21 01-50
@Wohlstand Wohlstand added the bug label Aug 20, 2018
@jpcima
Copy link
Collaborator

jpcima commented Aug 21, 2018 •
edited
Loading

EDIT I am able to reproduce the issue. Gotta look in more detail.

I'm not able to make the problem happen on my side unfortunately.
I've opened DMXOPL3-GS for a test and nothing happened.

@Wohlstand
Copy link
Owner Author

Wohlstand commented Aug 21, 2018 •
edited
Loading

This is not happens in OPL3-BE, happens on OPN2 - BE.

@freq-mod
Copy link
Contributor

It also affects melodic banks as well, steps to replicate:

  • take YM2612.wopn from https://github.com/papiezak/DMXOPN2
  • select GS bank no.1, click on any instrument...
  • ...and it should go down to a bottom of the list. What's weird it doesn't affect all banks in my case (for example, my Power Drumkit/GS Bank no. 2 behaves correctly :suspect:

@jpcima
Copy link
Collaborator

jpcima commented Aug 21, 2018

I've made some traces and don't find myself much more advanced about this issue.
It's curious how this problem happens within a delay of clicking on instruments.
(and to my knowledge there is nowhere a temporization such as timers)

One thing I found, it's maybe related with having hidden list items in the set.
If I comment the setHidden which makes rows invisible on a bank switch, the bug is not happening.

@Wohlstand
Copy link
Owner Author

Wohlstand commented Aug 21, 2018 •
edited
Loading

Seems it's a Qt side glitch...
so, is need to refactor the ssg-eg combobox to avoid elements are needs to be hidden

EDIT: Miss looked. Yeah, it's reasonable to begin replacement with QListView thing where the visibility management is under our control (On side of PGE Editor I have made itembox model where I have made flexible filter search with categories and groups. Originally on ListWidget the thing was a bit glitchy when doing filter search with same hiding of elements. With my model this crap has gone. Seems I need to backport my thing to here and use it... I'll try to do that at evening...

@Wohlstand
Copy link
Owner Author

Okay, after some other works (possibly with adding of grayed blank instruments), this bug has been gone!

@freq-mod
Copy link
Contributor

freq-mod commented Dec 20, 2018 •
edited
Loading

Well, apparently the bug is still here! It still drops down an entire list of patches:
bug stillhere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Wohlstand Wohlstand

@jpcima jpcima

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Wohlstand @jpcima @freq-mod