Skip to content

Commit

Permalink
Revert "put_aws_sigv4: Default :service to :s3"
Browse files Browse the repository at this point in the history
This reverts commit c753e65.
  • Loading branch information
wojtekmach committed Jul 8, 2024
1 parent a45e402 commit 7e1f105
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion lib/req.ex
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ defmodule Req do
* `:secret_access_key` - the AWS secret access key.
* `:service` - the AWS service. Defaults to `:s3`.
* `:service` - the AWS service.
* `:region` - if set, AWS region. Defaults to `"us-east-1"`.
Expand Down
4 changes: 2 additions & 2 deletions lib/req/steps.ex
Original file line number Diff line number Diff line change
Expand Up @@ -1104,7 +1104,7 @@ defmodule Req.Steps do
* `:token` - if set, the AWS security token, returned from AWS STS.
* `:service` - the AWS service. Defaults to `:s3`.
* `:service` - the AWS service.
* `:region` - the AWS region. Defaults to `"us-east-1"`.
Expand All @@ -1118,6 +1118,7 @@ defmodule Req.Steps do
...> aws_sigv4: [
...> access_key_id: System.get_env("AWS_ACCESS_KEY_ID"),
...> secret_access_key: System.get_env("AWS_SECRET_ACCESS_KEY"),
...> service: :s3
...> ]
...> )
iex>
Expand Down Expand Up @@ -1154,7 +1155,6 @@ defmodule Req.Steps do

aws_options =
aws_options
|> Keyword.put_new(:service, :s3)
|> Keyword.put_new(:region, "us-east-1")
|> Keyword.put_new(:datetime, DateTime.utc_now())
# aws_credentials returns this key so let's ignore it
Expand Down

0 comments on commit 7e1f105

Please sign in to comment.