Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My country week starts on Sunday #93

Closed
itayronen opened this issue Jul 18, 2018 · 5 comments
Closed

My country week starts on Sunday #93

itayronen opened this issue Jul 18, 2018 · 5 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@itayronen
Copy link

Hi,
I tried altering the locale and calendarType but I can't get the week to start on sunday (weekend is Friday-Saturday).
I read #10 and 'US' does put Sunday first but the weekend color is still on it.

Is there any way to make the work week Sunday to Thursday and the weekend Friday to Saturday?

Thanks,
Itay

@wojtekmaj
Copy link
Owner

Hi there,
I'm afraid that as we speak react-calendar assumes weekend is on Saturday and Sunday. Can you please share what locale has calendar starting on Sunday and has weekend from Friday to Saturday?

@wojtekmaj wojtekmaj self-assigned this Jul 23, 2018
@itayronen
Copy link
Author

itayronen commented Jul 23, 2018

Yes, I live in Israel, the locale is "he" (also "he-IL").
Just to be clear, when using the locale, the language is changing as expected (days and months names).

A quick solution (that I'm personally fine with) could be the option to turn off the weekend color and make it look the same as the work days.

@itayronen
Copy link
Author

https://en.wikipedia.org/wiki/Workweek_and_weekend
Sorting by "Working week", it looks like most of the middle-east countries are Sunday-Thursday.

@wojtekmaj wojtekmaj added the enhancement New feature or request label Aug 1, 2018
@wojtekmaj wojtekmaj added this to the 2.17.0 milestone Aug 8, 2018
@wojtekmaj
Copy link
Owner

wojtekmaj commented Aug 13, 2018

Fixed in 70f9ef4, will be released with the next release.

@wojtekmaj
Copy link
Owner

Hi @itayronen,
please read #102. Thanks in advance for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants