Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access to onOpen & onClose Events #12

Closed
Joeao opened this issue Nov 1, 2018 · 2 comments
Closed

Access to onOpen & onClose Events #12

Joeao opened this issue Nov 1, 2018 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@Joeao
Copy link

Joeao commented Nov 1, 2018

Hey guy,

Thanks for the awesome projects, been using this and calendar on my app.

A little feedback: Currently clicking on leading zeroes won't cause the calendar to appear. This is also the case with clicking the slashes between dates. I won't make assumptions as to whether this is intended behaviour, but it's something I'd like to change in my implementation.

I've tried manually forcing the calendar open when a click occurs on the input group wrapper by setting an open state on the parent onClick, but I can't tell the parent when the picker has closed, so it only works one time.

Having access to onOpen and onClose events regardless of a value change would help us have greater control over the picker. Therefore I request this as a feature.

Thanks a lot, let me know if I'm overlooking something. Or if this is something you're happy with including in the project I can make a pull request.

Joe

@wojtekmaj
Copy link
Owner

wojtekmaj commented Nov 12, 2018

Related to wojtekmaj/react-date-picker#120

@wojtekmaj wojtekmaj self-assigned this Nov 12, 2018
@wojtekmaj wojtekmaj added the enhancement New feature or request label Nov 12, 2018
@wojtekmaj
Copy link
Owner

Added in de1f7b7 and released in v2.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants