Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding missing layer 11 as 'Edge.Cuts' to fix the crash and add the solid region cut to pcbnew #46

Merged
merged 2 commits into from Dec 28, 2020

Conversation

zeevj
Copy link
Contributor

@zeevj zeevj commented Nov 5, 2020

No description provided.

@urish urish self-assigned this Nov 5, 2020
@urish
Copy link
Collaborator

urish commented Nov 5, 2020

Thank you! Can you please give an example of an EasyEDA file with layer 11?

@zeevj
Copy link
Contributor Author

zeevj commented Nov 6, 2020

For some reason I had a Solid Region + Multi-Layer + type: Solid (This is what generated layer 11)
easyeda_project_file.json

@zeevj
Copy link
Contributor Author

zeevj commented Nov 6, 2020

So now if I fix the faulty value (from solid to board cutout) the script does't "cut" the board ( "Warning: unsupported SOLIDREGION type npth")
handling 'npth' the same as 'solid' is enough to fix it.
Will add it to the pull request

@urish urish merged commit b5f06e6 into wokwi:master Dec 28, 2020
@urish
Copy link
Collaborator

urish commented Dec 28, 2020

Thank you!

@urish
Copy link
Collaborator

urish commented Dec 28, 2020

Fix deployed on https://wokwi.com/easyeda2kicad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants