Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rust-training-esp32c3 image #29

Merged
merged 8 commits into from
Mar 28, 2023

Conversation

SergioGasquez
Copy link
Contributor

Our training had a big revamp: esp-rs/std-training#152 and now the Dockerfile from the training gets published in dockerhub.

I will try to create a project for the exercise and solution for all the projects of the training and link them in the training content.

@urish
Copy link
Contributor

urish commented Mar 27, 2023

Thanks! A questions + request:

  1. Is it possible to switch to non-root user? Running under root increases the attack surface of the builder.
  2. Please add all the HEXI_ environment variables to the Dockerfile (the ones that you used to test the container), similar to what we have here:
    ENV HEXI_SRC_DIR="/home/esp/build-in"
    ENV HEXI_BUILD_CMD="bash /home/esp/compile.sh"
    ENV HEXI_OUT_HEX="/home/esp/build-out/project.bin"
    ENV HEXI_OUT_ELF="/home/esp/build-out/project.elf"

@urish
Copy link
Contributor

urish commented Mar 27, 2023

Thanks! What about running the build as non-root user?

@SergioGasquez
Copy link
Contributor Author

Thanks! What about running the build as non-root user?

I am currently doing some testing on that end, sorry I didn't update you. I started doing test and forgot about updating here.
Will keep you posted!

@urish
Copy link
Contributor

urish commented Mar 27, 2023

Thank you!

@urish
Copy link
Contributor

urish commented Mar 28, 2023

Ready to merge?

@SergioGasquez
Copy link
Contributor Author

Ready to merge?

Not yet! Give me a moment to do a round of testing!

@SergioGasquez
Copy link
Contributor Author

I think now it should be ready to merge!

@urish urish merged commit db2ffcd into wokwi:main Mar 28, 2023
@SergioGasquez SergioGasquez deleted the feature/training-update branch March 28, 2023 12:44
@urish
Copy link
Contributor

urish commented Mar 28, 2023

Thanks! Uploading it now, should be up in ~10 minutes or so

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants