Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw exceptions from nested objects #18

Merged
merged 1 commit into from
Jul 21, 2020

Conversation

wol-soft
Copy link
Owner

Don't pass an error registry exception into a nested object and add errors to the passed exception. Instead always throw an exception from generated objects and catch those exceptions inside a parent model.

…rrors to the passed exception. Instead always throw an exception from generated objects and catch those exceptions inside a parent model.
@coveralls
Copy link

coveralls commented Jul 21, 2020

Pull Request Test Coverage Report for Build 294

  • 14 of 14 (100.0%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 98.306%

Totals Coverage Status
Change from base Build 292: 0.003%
Covered Lines: 1683
Relevant Lines: 1712

💛 - Coveralls

@wol-soft wol-soft merged commit 892f4a5 into master Jul 21, 2020
@wol-soft wol-soft deleted the ThrowExceptionFromNestedModel branch July 21, 2020 17:32
@wol-soft wol-soft added this to the 0.18.0 milestone Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants