Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize package names in simple index #37

Closed
wolever opened this issue Jan 9, 2015 · 5 comments
Closed

Normalize package names in simple index #37

wolever opened this issue Jan 9, 2015 · 5 comments

Comments

@wolever
Copy link
Owner

wolever commented Jan 9, 2015

It seems like pip[0] and bandersnatch[1] are now normalizing package names in the simple index, so for example simple/Django/Django-1.7.tar.gz becomes simple/dango/Django-1.7.tar.gz.

As of 0.6.5 pip2pi will include a --normalize-package-names option (default: disabled) and will issue a deprecation warning when it encounters a non-normalized package name. If no issues are found by about June 2015 --normalize-package-names will become the default.

Thanks to @orodbhen for initially reporting this: #35. See also: pypa/pip#2136

0: pypa/pip#2001
1: https://bitbucket.org/pypa/bandersnatch/pull-request/7/prefer-normalized-directory-names-but-keep/diff

@wolever
Copy link
Owner Author

wolever commented Jan 9, 2015

And pip2pi 0.6.5 has been pushed to PyPI. Comments would be great!

@jchysk
Copy link

jchysk commented Jan 23, 2015

Works pretty well, but I still receive deprecation warnings on packages with underscores. Those underscores are checked as hyphens when the dependency is being grabbed.

@adamkerz
Copy link

adamkerz commented Mar 3, 2015

pkg_resources.safe_name(x).lower() is what's being used in bandersnatch. Isn't that what we should be doing too?

@mcameron
Copy link

mcameron commented Oct 8, 2015

Installing httpretty with pip2pi --normalise-package-names errors with file not found readme.rst (file is README.rst). Installing without --normalise-package-names gives: WARNING: Non-normalized packages encountered.

@wolever
Copy link
Owner Author

wolever commented Sep 21, 2016

The most recent version, 0.7.0rc1, should correctly normalize package names.

Would you be able to install it:

pip install pip2pi==0.7.0rc1

And, if it isn't fixed, can you comment on #55?

@wolever wolever closed this as completed Sep 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants