Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warning about normalized names unclear #2136

Closed
orodbhen opened this issue Nov 21, 2014 · 4 comments
Closed

Deprecation warning about normalized names unclear #2136

orodbhen opened this issue Nov 21, 2014 · 4 comments
Labels
auto-locked Outdated issues that have been locked by automation

Comments

@orodbhen
Copy link

After creating a package index for our LAN using the dir2pi tool, I had to install the dev version of pip in order to get case-insensitive searches on a file:/// url.

However, now I get this warning:

"DEPRECATION: One or more of your dependencies required using a deprecated fallback to looking at /simple/ to discover it's real name. It is suggested to upgrade your index to support normalized names as the name in /simple/{name}."

I'm not really sure what is meant by this, or how to comply with it.

I read through this discusssion, but I'm still not clear on what the new directory structure of the index should be.

Perhaps a link to the documentation for this deprecation could be added to the warning message.

@dstufft
Copy link
Member

dstufft commented Nov 21, 2014

The names like packages/simple/Bar/bar-0.8.tar.gz need normalized to packages/simple/bar/bar-0.8.tar.gz where normalization is basically pkg_resources.safe_name.

@orodbhen
Copy link
Author

Thanks for the quick response.

So do the names of the package directories only need to be changed, or the names of the package archives as well?

@dstufft
Copy link
Member

dstufft commented Nov 21, 2014

Just the names of the directories. This was primarily aimed at HTTP where we wanted to be able to know ahead of time given something like pip install Foo what URL should we request so as not to get a redirect (on PyPI) or fall back to fetching the index to discover the "real" name (Bandersnatch, dir2pi, etc). Since authors could register Foo or foo or fOo and we had no way to determine what it should be we moved towards normalization so that there is a deterministic method of obtaining the expected /simple/{insert name}/ path for any particular dependency.

@orodbhen
Copy link
Author

Ok. I'll need to patch dir2pi then, so it will normalize the directory names. Thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation
Projects
None yet
Development

No branches or pull requests

2 participants