Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dsp/gui inconsistencies and improve generic UI #160

Merged
merged 4 commits into from
Jan 22, 2023

Conversation

falkTX
Copy link
Contributor

@falkTX falkTX commented Jan 3, 2023

Changes should be self-explanatory, but to summarize:

  • DSP and UI should start with the same state, otherwise UI will show incorrect values
  • Enumerations are nice so hosts that use generic UI can show those as the real parameter values instead of just numbers
  • The gain controls were set as logarithmic, but no log scale was ever in use in the GUI, removed the hint to make DSP side behave the same as the UI does

Signed-off-by: falkTX <falktx@falktx.com>
Signed-off-by: falkTX <falktx@falktx.com>
Signed-off-by: falkTX <falktx@falktx.com>
@pdesaulniers
Copy link
Member

LGTM! However, do you know if these changes could introduce backward compatibility issues in some hosts? For instance, could automation behave differently if we change the scale of the gain parameters from logarithmic to linear?

@falkTX
Copy link
Contributor Author

falkTX commented Jan 16, 2023

For instance, could automation behave differently if we change the scale of the gain parameters from logarithmic to linear?

On LV2 where the host reads those flags, it uses real values so it will keep being the same.
On VST2/3, maybe.. but this was always wrong anyhow since you cant have log scale with a 0 target (min or max)

Signed-off-by: falkTX <falktx@falktx.com>
@pdesaulniers
Copy link
Member

Good, I'm merging this. Thanks!

@pdesaulniers pdesaulniers merged commit c4aa209 into wolf-plugins:master Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants