Make variables volatile in get_blob_* functions #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compiler optimizations will cause some values to be optimized out, when reading parameters from the flash. Using 'volatile' in these functions results in values being correctly updated. This should fix the issue reported in wolfSSL#249.
dgarske
requested changes
Nov 28, 2022
| @@ -574,7 +574,7 @@ int wolfBoot_get_delta_info(uint8_t part, int inverse, uint32_t **img_offset, | |||
|
|
|||
| uint32_t wolfBoot_get_blob_version(uint8_t *blob) | |||
| { | |||
| uint32_t *version_field = NULL; | |||
| uint32_t *volatile version_field = NULL; | |||
There was a problem hiding this comment.
Syntax format is usually volatile uint32_t* version_field = NULL;. Can you update these?
There was a problem hiding this comment.
Sorry about that. I see now it is the pointer that you want to be volatile.
dgarske
approved these changes
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiler optimizations will cause some values to be optimized out, when reading parameters from the flash.
Using 'volatile' in these functions results in values being correctly updated.
This should fix the issue reported in #249 .