Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed erroneous file generation on ecc keygen #125

Merged
merged 3 commits into from
Jun 21, 2023
Merged

removed erroneous file generation on ecc keygen #125

merged 3 commits into from
Jun 21, 2023

Conversation

bigbrett
Copy link
Contributor

@bigbrett bigbrett commented May 31, 2023 •
edited
Loading

Changes introduced

  1. Fixes bug where generating an ECC key created a zero-byte file alongside the output keys.
  2. Unifies the seemingly redundant PUB_ONLY/PRIV_ONLY and PUB_ONLY_FILE/PRIV_ONLY_FILE enums

How to reproduce bug in 1.

Running the following command on a build based on the main branch:

./wolfssl genkey ecc -out mykey -outform pem -output KEYPAIR

generates mykey.priv and mykey.pub but also the empty file mykey.

This PR should eliminate the extra mykey file

@bigbrett bigbrett marked this pull request as ready for review June 5, 2023 16:51
@JacobBarthelmeh JacobBarthelmeh merged commit d82ad5c into wolfSSL:main Jun 21, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacobBarthelmeh JacobBarthelmeh JacobBarthelmeh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bigbrett @JacobBarthelmeh