Add mutex protection to MqttClient_NetDisconnect #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No idea why the macOS Build Test is failing |
lealem47
approved these changes
Jul 19, 2023
lealem47
requested changes
Jul 19, 2023
embhorn
commented
Jul 19, 2023
|
|
||
| #ifdef WOLFMQTT_MULTITHREAD | ||
| /* Get client lock on to ensure no other threads are active */ | ||
| wm_SemLock(&client->lockClient); |
There was a problem hiding this comment.
@dgarske - I removed the locks for send and recv because they should not be required for modifying the pending response list. Also was causing a failure in the MacOS CI test.
There was a problem hiding this comment.
How do we know the socket isn't busy in another thread, or do we let the OS handle that socket sig?
There was a problem hiding this comment.
From this API, we are not doing IO directly, so it's okay if other threads are using the socket.
dgarske
approved these changes
Jul 19, 2023
lealem47
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds mutex protection and cancels all pending messages in
MqttClient_NetDisconnectFixes zd16343
Customer confirms fix.