Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding publish and subscribe atomic client examples #347

Merged
merged 1 commit into from Oct 12, 2023

Conversation

embhorn
Copy link
Member

@embhorn embhorn commented Aug 15, 2023

New examples in examples/pub-sub

These can be used for quickly testing MQTT application or scripting.

By default, they connect to localhost. Specify a topic with -n
./examples/pub-sub/mqtt-sub -n '#'

./examples/pub-sub/mqtt-pub -n test -m "Hello world!"

Enable verbose example debug with -d

@embhorn embhorn self-assigned this Aug 15, 2023
@embhorn embhorn requested a review from lealem47 August 15, 2023 14:06
Copy link
Contributor

@lealem47 lealem47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great. Should there be a new test script for the pub-sub clients?

examples/pub-sub/mqtt-pub.c Outdated Show resolved Hide resolved
examples/pub-sub/mqtt-pub.c Outdated Show resolved Hide resolved
examples/pub-sub/mqtt-sub.c Outdated Show resolved Hide resolved
@embhorn
Copy link
Member Author

embhorn commented Aug 15, 2023

Should there be a new test script for the pub-sub clients?

I hadn't considered this. These are really just subsets of the mqttclient example. They could be used for testing against the protocol.

@lealem47 lealem47 self-requested a review August 15, 2023 21:41
lealem47
lealem47 previously approved these changes Aug 15, 2023
@embhorn
Copy link
Member Author

embhorn commented Aug 16, 2023

Fixed executable names in .gitignore

@embhorn embhorn requested a review from dgarske August 22, 2023 17:04
Copy link
Contributor

@dgarske dgarske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good and tests out. I notice these aren't being used yet. Are you planning to add some additional scripts to test using these?

@embhorn
Copy link
Member Author

embhorn commented Aug 22, 2023

All looks good and tests out. I notice these aren't being used yet. Are you planning to add some additional scripts to test using these?

Yes, that is the intention, to better enable functional testing using these clients.

@dgarske dgarske merged commit 62fb8f2 into wolfSSL:master Oct 12, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants