Fixes for non-blocking edge cases #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
embhorn
previously approved these changes
Oct 20, 2023
dgarske
force-pushed
the
pub_cont
branch
8 times, most recently
from
83aceda
to
cea5a27
Compare
…buffer. ZD 16769 * Fixes for write non-blocking (would block) edge cases. * Fix for write position on cancel of message in progress. * Added check for zero return on read, which is a compatibility layer indicator for disconnect.
* Fix to make sure ctrl+c is honored during a want read/write case. * Fix the firmware update example to properly synchronize publish and use a unique topic name. * Improve multi-thread test message to use larger size (> tx but) and in test mode check for actual message. * Improve remote test done logic. * Only run GitHub CI for PR's, not local push. * Properly set `WOLFMQTT_NO_EXTERNAL_BROKER_TESTS` for each test. * Use cat for logs, not more.
embhorn
requested changes
Oct 27, 2023
| @@ -88,4 +88,4 @@ jobs: | |||
| - name: Show logs on failure | |||
| if: failure() || cancelled() | |||
| run: | | |||
| more test-suite.log | |||
| cat test-suite.log | |||
There was a problem hiding this comment.
This was failing for me when I tried it. more did not have any problem. I think the error was file "test-suite.log" does not exist
| @@ -97,4 +103,4 @@ jobs: | |||
| - name: Show logs on failure | |||
| if: failure() || cancelled() | |||
| run: | | |||
| more test-suite.log | |||
| cat test-suite.log | |||
dgarske
changed the title
embhorn
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WOLFMQTT_NO_EXTERNAL_BROKER_TESTSfor each test.