Added support for disconnect callback #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacobBarthelmeh
requested changes
May 23, 2018
examples/mqttclient/mqttclient.c
Outdated
| @@ -141,6 +151,11 @@ int mqttclient_test(MQTTCtx *mqttCtx) | |||
| } | |||
| mqttCtx->client.ctx = mqttCtx; | |||
|
|
|||
| #ifdef WOLFMQTT_DISCONNECT_CB | |||
| /* setup disconnect callback */ | |||
| MqttClient_SetDisconnectCallback(&mqttCtx->client, mqtt_disconnect_cb, NULL); | |||
There was a problem hiding this comment.
check of return value here
src/mqtt_packet.c
Outdated
| rc != MQTT_CODE_STDIN_WAKE) | ||
| { | ||
| /* don't use return code for now - future use */ | ||
| client->disconnect_cb(client, rc, client->disconnect_ctx); |
There was a problem hiding this comment.
please add NULL check for disconnect_cb here
…NECT_CB` or `./configure --enable-discb`.
|
@JacobBarthelmeh : Pushed fixes. Added checks for null and return code. Thanks! |
JacobBarthelmeh
approved these changes
May 25, 2018
kojo1
pushed a commit
to kojo1/wolfMQTT
that referenced
this pull request
Aug 21, 2022
Sanity check for aligned fields in manifest header Fix confirmed (thanks @guidovranken !)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabled using
WOLFMQTT_DISCONNECT_CBor./configure --enable-discb.