PKCS11 TPM support #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgarske
force-pushed
the
pkcs11_tpm
branch
5 times, most recently
from
643dd33
to
8a2eae2
Compare
dgarske
force-pushed
the
pkcs11_tpm
branch
2 times, most recently
from
1fd117e
to
9de6d53
Compare
…and supports RSA and ECC. Requires wolfSSL/wolfTPM#311 Added CI testing for wolfPKCS11 with wolfTPM backend and single threaded.
SparkiDev
previously approved these changes
Nov 30, 2023
dgarske
force-pushed
the
pkcs11_tpm
branch
3 times, most recently
from
f61e105
to
52711af
Compare
…O_ENV` when setenv/getenv is not available. Only require `-ldl` for non-static builds.
|
@SparkiDev this is ready for your review and finalization. I'll followup with any portability issues in a new PR. |
SparkiDev
requested changes
Dec 5, 2023
src/internal.c
Outdated
| case WOLFPKCS11_STORE_DHKEY_PRIV: | ||
| case WOLFPKCS11_STORE_DHKEY_PUB: | ||
| default: | ||
| maxSz = -1; |
src/internal.c
Outdated
| /** | ||
| * Free dynamic memory associated with the slot. | ||
| * | ||
| * @param slot [in] Slot object. | ||
| */ | ||
| static void wp11_Slot_Final(WP11_Slot* slot) | ||
| { | ||
| if (slot == NULL) return; |
src/internal.c
Outdated
| @@ -3001,6 +3271,11 @@ static int wp11_Slot_Init(WP11_Slot* slot, int id) | |||
|
|
|||
| ret = WP11_Lock_Init(&slot->lock); | |||
| if (ret == 0) { | |||
| #ifdef WOLFPKCS11_TPM | |||
| if (ret == 0) { | |||
There was a problem hiding this comment.
'ret == 0' checks look wrong
SparkiDev
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires Add TPM crypto callback support for RSA key generation wolfTPM#311
WOLFPKCS11_TPM_STORE).