Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microchip macro names and Support for bench with MPLABX Harmony #256

Merged
merged 2 commits into from Feb 3, 2023

Conversation

dgarske
Copy link
Contributor

@dgarske dgarske commented Feb 1, 2023

Fix for Microchip Harmony build settings. Rename to WOLFTPM_MICROCHIP_HARMONY. Avoids confusion with the TPM 2.0 module ATTPM from Microchip. Now enabled with WOLFTPM_MICROCHIP and provides backwards compatibility for WOLFTPM_MCHP. The new WOLFTPM_MICROCHIP has not been released (was added in PR #251).

Support for TPM benchmarking with Microchip MPLABX (WOLFTPM_MICROCHIP_HARMONY ).

ZD 15350

@dgarske dgarske self-assigned this Feb 1, 2023
@dgarske
Copy link
Contributor Author

dgarske commented Feb 3, 2023

TODO: Fix use of WOLFTPM_MICROCHIP to be MPLABX or Harmony. The ATTPM20 uses WOLFTPM_MCHP. Confusing.

…P_HARMONY`. Avoids confusion with the TPM 2.0 module ATTPM from Microchip. Now enabled with `WOLFTPM_MICROCHIP` and provides backwards compatibility for `WOLFTPM_MCHP`. The new `WOLFTPM_MICROCHIP` has not been released (was added in PR wolfSSL#251).
@dgarske dgarske changed the title Support for TPM benchmarking with Microchip MPLABX Microchip macro names and Support for bench with Microchip MPLABX Harmony Feb 3, 2023
@dgarske dgarske changed the title Microchip macro names and Support for bench with Microchip MPLABX Harmony Microchip macro names and Support for bench with MPLABX Harmony Feb 3, 2023
@dgarske dgarske assigned jpbland1 and unassigned dgarske Feb 3, 2023
Copy link
Contributor

@jpbland1 jpbland1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, much more clear on the flags

@jpbland1 jpbland1 merged commit 8181987 into wolfSSL:master Feb 3, 2023
@dgarske dgarske deleted the microchip_bench branch June 28, 2023 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants