Adding STM32 Expansion Pack #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgarske
requested changes
Aug 2, 2023
IDE/STM32CUBE/wolftpm_test.c
Outdated
| printf("Running wolfTPM Tests...\n"); | ||
|
|
||
| /* Run wolfTPM unit tests */ | ||
| if (unit_tests(0, NULL)) |
There was a problem hiding this comment.
I'd prefer the wrap_test, not the unit test.
IDE/STM32CUBE/default_conf.ftl
Outdated
|
|
||
| #undef USE_HW_SPI_CS | ||
| #if defined(WOLFTPM_CONF_HW_SPI) && WOLFTPM_CONF_HW_SPI == 1 | ||
| #define USE_HW_SPI_CS |
There was a problem hiding this comment.
Please use 4 spaces, not tabs (also above). What is USE_HW_SPI_CS?
There was a problem hiding this comment.
Done. It guards the calls to GPIO_WRITE_PIN(). I thought it would be something users want to toggle based off the OPENSTM32 user_setting.h
dgarske
requested changes
Aug 3, 2023
IDE/STM32CUBE/wolftpm_test.h
Outdated
| #include <config.h> | ||
| #endif | ||
|
|
||
| int TPM2_Wrapper_Test(void* userCtx); |
There was a problem hiding this comment.
This can come from examples/wrap/wrap_test.h or just put in the .c file and use extern int TPM2_Wrapper_Test(void* userCtx);.
IDE/STM32CUBE/wolftpm_test.h
Outdated
| @@ -0,0 +1,40 @@ | |||
| /* wolfssh_test.h | |||
IDE/STM32CUBE/wolftpm_test.c
Outdated
| #endif | ||
| { | ||
| int ret = 0; | ||
| #if 0 |
There was a problem hiding this comment.
You can remove this. The TPM2_WolfCrypt_Init already has DEBUG_WOLFSSL and this call.
dgarske
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.