TPM command authentication refactor #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpbland1
requested changes
Oct 12, 2023
src/tpm2.c
Outdated
| @@ -2754,14 +2697,15 @@ TPM_RC TPM2_GetCommandAuditDigest(GetCommandAuditDigest_In* in, | |||
| TPM2_Packet packet; | |||
| CmdInfo_t info = {0,0,0,0}; | |||
| info.inHandleCnt = 2; | |||
| info.flags = (CMD_FLAG_ENC2 | CMD_FLAG_DEC2); | |||
| info.flags = (CMD_FLAG_ENC2 | CMD_FLAG_DEC2 | | |||
| CMD_FLAG_AUTH_USER1 | CMD_FLAG_AUTH_USER1); | |||
| for (i=0; i<info->authCnt; i++) { | ||
| /* Note: Casting a TPM2_AUTH_SESSION to TPMS_AUTH_COMMAND here, | ||
| * this is allowed because top of structure matches */ | ||
| TPM2_Packet_AppendAuthCmd(packet, (TPMS_AUTH_COMMAND*)&ctx->session[i]); |
There was a problem hiding this comment.
Is it possible for the indices to be mismatched here? For example suppose TPM2_GetCmdAuthCount incremented authSessCount for indices 0 and 2 with a count of 2. Wouldn't this use indices 0 and 1 instead of 0 and 2?
…uth do not supply it. ZD 16689
dgarske
force-pushed
the
auth_refactor
branch
from
493e448
to
cdcdf38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor of the command authentication. If command does not require auth do not supply it. ZD 16689