Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes and improvements for wolfTPM CSR wrappers #307

Merged
merged 4 commits into from Oct 23, 2023
Merged

Fixes and improvements for wolfTPM CSR wrappers #307

merged 4 commits into from Oct 23, 2023

Conversation

dgarske
Copy link
Contributor

@dgarske dgarske commented Oct 18, 2023 •
edited

  • Fix for trying to use a custom wolfTPM CSR sigType. The csr->req.sigType was being initialized to CTC_SHA256wRSA, and not allowing override.
  • Add wrapper support for setting key usage (not just extended key usage).
  • Fix support for ECC 384-bit only support. Tested with: ./configure --enable-wolftpm CFLAGS="-DECC_USER_CURVES -DNO_ECC256 -DHAVE_ECC384" --disable-examples --disable-crypttests && make
  • Add CI tests for CSharp wrappers.

@dgarske
Fix for trying to use a custom wolfTPM CSR sigType. The `csr->req.s…
b9c5133 
…igType` was being initialized to CTC_SHA256wRSA, and not allowing override.
@dgarske dgarske self-assigned this Oct 18, 2023
@dgarske
Copy link
Contributor Author

dgarske commented Oct 19, 2023

I am going to add a test case for this.

@dgarske
Add wrapper support for setting key usage (not just extended key usage).
8ae11cf
@dgarske
Fix support for ECC 384-bit only support. Tested with: `./configure -…
7a11cb2 
…-enable-wolftpm CFLAGS="-DECC_USER_CURVES -DNO_ECC256 -DHAVE_ECC384" --disable-examples --disable-crypttests && make`
@dgarske dgarske changed the title Fix for trying to use a custom wolfTPM CSR sigType Fixes and improvements for wolfTPM CSR wrappers Oct 20, 2023
@dgarske dgarske force-pushed the csr_sigtype branch 2 times, most recently from acbbf06 to de35c64 Compare October 23, 2023 16:08
@dgarske dgarske requested a review from jpbland1 October 23, 2023 18:38
@dgarske dgarske removed the request for review from JacobBarthelmeh October 23, 2023 18:39
jpbland1
jpbland1 approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@jpbland1 jpbland1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jpbland1 jpbland1 merged commit 45847e3 into wolfSSL:master Oct 23, 2023
1 check passed
@dgarske dgarske deleted the csr_sigtype branch December 29, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpbland1 jpbland1 jpbland1 approved these changes

Assignees

@jpbland1 jpbland1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dgarske @jpbland1 @JacobBarthelmeh @wolfSSL-Bot