Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

be more lenient on CR with protocol exchange #213

Merged
merged 4 commits into from
Mar 18, 2020

Conversation

JacobBarthelmeh
Copy link
Contributor

No description provided.

@ejohnstown
Copy link
Contributor

When I enable WOLFSSH_STRICT_PROTOCOL_EXCHANGE, and send a protocol ID string that doesn't end in CRLF, the code hangs. It looks like it is waiting for the CRLF explicitly. (I denormalized the code to only send the LF in the protocol ID string.)

@JacobBarthelmeh
Copy link
Contributor Author

When I enable WOLFSSH_STRICT_PROTOCOL_EXCHANGE, and send a protocol ID string that doesn't end in CRLF, the code hangs. It looks like it is waiting for the CRLF explicitly. (I denormalized the code to only send the LF in the protocol ID string.)

Thanks for the review. Looks like that hang is in master too. The while loop keeps looking for the \r\n I almost think we should remove the while loop here and report back to calling functions instead?

@JacobBarthelmeh JacobBarthelmeh self-assigned this Nov 6, 2019
@JacobBarthelmeh
Copy link
Contributor Author

Conversed with John about advancement of IDX being 1 instead of default 2 in the case of just '\n' without '\r\n'. Am working on a code change to account for this.

@ejohnstown ejohnstown merged commit 80760b5 into wolfSSL:master Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants