Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failure on big endian platforms (e.g. IBM Z/s390x) #3240

Closed
tobiasbrunner opened this issue Aug 24, 2020 · 3 comments
Closed

Build failure on big endian platforms (e.g. IBM Z/s390x) #3240

tobiasbrunner opened this issue Aug 24, 2020 · 3 comments
Assignees

Comments

@tobiasbrunner
Copy link

The #ifdef around ByteReverseWords that was added with cebb283 and released with 4.5.0 breaks the build on big endian platforms (e.g. on s390x on Travis CI, see here):

wolfcrypt/src/md5.c: In function ‘wc_Md5Update���:
wolfcrypt/src/md5.c:378:13: error: implicit declaration of function ‘ByteReverseWords’; did you mean ‘ByteReverseWords64’? [-Werror=implicit-function-declaration]
             ByteReverseWords(md5->buffer, md5->buffer, WC_MD5_BLOCK_SIZE);
             ^~~~~~~~~~~~~~~~
             ByteReverseWords64
wolfcrypt/src/md5.c:378:13: error: nested extern declaration of ‘ByteReverseWords’ [-Werror=nested-externs]
@kaleb-himes
Copy link
Contributor

@tmael,

Can you review the changes here: cebb283#diff-4be40df89ec617072a3441685b231559R123-R134

Thanks!

  • KH

@tmael
Copy link
Contributor

tmael commented Aug 26, 2020

Hi @tobiasbrunner and @kaleb-himes,

I've opened PR #3255 to fix the issue.

Thanks

@tobiasbrunner
Copy link
Author

I successfully tested e9b1cea. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants