Make ByteReverseWords available for big and little endian #3255

tmael · 2020-08-26T17:28:05Z

This PR fixes a build error by removing the ifdef endianess check around ByteReverseWords().
It turned out some libraries (e.g. md4.c) default to checking BIG_ENDIAN_ORDER before calling ByteReverseWords() while other modules such as sha256.c check LITTLE_ENDIAN_ORDER before calling ByteReverseWords(). So ByteReverseWords() needs to be available for both big and little-endian systems.

Steps to reproduce error:
./configure CFLAGS="-DBIG_ENDIAN_ORDER" --enable-md4
make

wolfcrypt/src/md4.c: In function ‘wc_Md4Update’:
wolfcrypt/src/md4.c:156:17: error: implicit declaration of function ‘ByteReverseWords’; did you mean ‘ByteReverseWords64’? [-Werror=implicit-function-declaration]
                 ByteReverseWords(md4->buffer, md4->buffer, MD4_BLOCK_SIZE);
                 ^~~~~~~~~~~~~~~~
                 ByteReverseWords64
wolfcrypt/src/md4.c:156:17: error: nested extern declaration of ‘ByteReverseWords’ [-Werror=nested-externs]
  CC       wolfcrypt/src/src_libwolfssl_la-chacha20_poly1305.lo
cc1: all warnings being treated as errors
Makefile:4667: recipe for target 'wolfcrypt/src/src_libwolfssl_la-md4.lo' failed
make[1]: *** [wolfcrypt/src/src_libwolfssl_la-md4.lo] Error 1
make[1]: *** Waiting for unfinished jobs....
wolfcrypt/src/md5.c: In function ‘wc_Md5Update’:
wolfcrypt/src/md5.c:378:13: error: implicit declaration of function ‘ByteReverseWords’; did you mean ‘ByteReverseWords64’? [-Werror=implicit-function-declaration]
             ByteReverseWords(md5->buffer, md5->buffer, WC_MD5_BLOCK_SIZE);
             ^~~~~~~~~~~~~~~~
             ByteReverseWords64
wolfcrypt/src/md5.c:378:13: error: nested extern declaration of ‘ByteReverseWords’ [-Werror=nested-externs]
cc1: all warnings being treated as errors
Makefile:4674: recipe for target 'wolfcrypt/src/src_libwolfssl_la-md5.lo' failed
make[1]: *** [wolfcrypt/src/src_libwolfssl_la-md5.lo] Error 1
make[1]: Leaving directory '/home/tesfa/wolfssl'
Makefile:3141: recipe for target 'all' failed
make: *** [all] Error 2

dgarske

Change is approved. Jenkins... contend with you will.

This fixes the following security problems: * In earlier versions of wolfSSL there exists a potential man in the middle attack on TLS 1.3 clients. * Denial of service attack on TLS 1.3 servers from repetitively sending ChangeCipherSpecs messages. (CVE-2020-12457) * Potential cache timing attacks on public key operations in builds that are not using SP (single precision). (CVE-2020-15309) * When using SGX with EC scalar multiplication the possibility of side- channel attacks are present. * Leak of private key in the case that PEM format private keys are bundled in with PEM certificates into a single file. * During the handshake, clear application_data messages in epoch 0 are processed and returned to the application. Full changelog: https://www.wolfssl.com/docs/wolfssl-changelog/ Fix a build error on big endian systems by backporting a pull request: wolfSSL/wolfssl#3255 The size of the ipk increases on mips BE by 1.4% old: libwolfssl24_4.4.0-stable-2_mips_24kc.ipk: 386246 new: libwolfssl24_4.5.0-stable-1_mips_24kc.ipk: 391528 Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>

dgarske · 2020-08-29T16:08:49Z

Retest this please

This fixes the following security problems: * In earlier versions of wolfSSL there exists a potential man in the middle attack on TLS 1.3 clients. * Denial of service attack on TLS 1.3 servers from repetitively sending ChangeCipherSpecs messages. (CVE-2020-12457) * Potential cache timing attacks on public key operations in builds that are not using SP (single precision). (CVE-2020-15309) * When using SGX with EC scalar multiplication the possibility of side- channel attacks are present. * Leak of private key in the case that PEM format private keys are bundled in with PEM certificates into a single file. * During the handshake, clear application_data messages in epoch 0 are processed and returned to the application. Full changelog: https://www.wolfssl.com/docs/wolfssl-changelog/ Fix a build error on big endian systems by backporting a pull request: wolfSSL/wolfssl#3255 The size of the ipk increases on mips BE by 1.4% old: libwolfssl24_4.4.0-stable-2_mips_24kc.ipk: 386246 new: libwolfssl24_4.5.0-stable-1_mips_24kc.ipk: 391528 Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de> (cherry picked from commit 00722a7)

This fixes the following security problems: * In earlier versions of wolfSSL there exists a potential man in the middle attack on TLS 1.3 clients. * Denial of service attack on TLS 1.3 servers from repetitively sending ChangeCipherSpecs messages. (CVE-2020-12457) * Potential cache timing attacks on public key operations in builds that are not using SP (single precision). (CVE-2020-15309) * When using SGX with EC scalar multiplication the possibility of side- channel attacks are present. * Leak of private key in the case that PEM format private keys are bundled in with PEM certificates into a single file. * During the handshake, clear application_data messages in epoch 0 are processed and returned to the application. Full changelog: https://www.wolfssl.com/docs/wolfssl-changelog/ Fix a build error on big endian systems by backporting a pull request: wolfSSL/wolfssl#3255 The size of the ipk increases on mips BE by 1.4% old: libwolfssl24_4.4.0-stable-2_mips_24kc.ipk: 386246 new: libwolfssl24_4.5.0-stable-1_mips_24kc.ipk: 391528 Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>

This fixes the following security problems: * In earlier versions of wolfSSL there exists a potential man in the middle attack on TLS 1.3 clients. * Denial of service attack on TLS 1.3 servers from repetitively sending ChangeCipherSpecs messages. (CVE-2020-12457) * Potential cache timing attacks on public key operations in builds that are not using SP (single precision). (CVE-2020-15309) * When using SGX with EC scalar multiplication the possibility of side- channel attacks are present. * Leak of private key in the case that PEM format private keys are bundled in with PEM certificates into a single file. * During the handshake, clear application_data messages in epoch 0 are processed and returned to the application. Full changelog: https://www.wolfssl.com/docs/wolfssl-changelog/ Fix a build error on big endian systems by backporting a pull request: wolfSSL/wolfssl#3255 The size of the ipk increases on mips BE by 1.4% old: libwolfssl24_4.4.0-stable-2_mips_24kc.ipk: 386246 new: libwolfssl24_4.5.0-stable-1_mips_24kc.ipk: 391528 Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de> (cherry picked from commit 00722a7)

This fixes the following security problems: * In earlier versions of wolfSSL there exists a potential man in the middle attack on TLS 1.3 clients. * Denial of service attack on TLS 1.3 servers from repetitively sending ChangeCipherSpecs messages. (CVE-2020-12457) * Potential cache timing attacks on public key operations in builds that are not using SP (single precision). (CVE-2020-15309) * When using SGX with EC scalar multiplication the possibility of side- channel attacks are present. * Leak of private key in the case that PEM format private keys are bundled in with PEM certificates into a single file. * During the handshake, clear application_data messages in epoch 0 are processed and returned to the application. Full changelog: https://www.wolfssl.com/docs/wolfssl-changelog/ Fix a build error on big endian systems by backporting a pull request: wolfSSL/wolfssl#3255 The size of the ipk increases on mips BE by 1.4% old: libwolfssl24_4.4.0-stable-2_mips_24kc.ipk: 386246 new: libwolfssl24_4.5.0-stable-1_mips_24kc.ipk: 391528 Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>

Make ByteReverseWords available for big and little endian

b90acc9

tmael requested a review from dgarske August 26, 2020 17:40

tmael mentioned this pull request Aug 26, 2020

Build failure on big endian platforms (e.g. IBM Z/s390x) #3240

Closed

tmael assigned dgarske Aug 26, 2020

dgarske approved these changes Aug 26, 2020

View reviewed changes

dgarske merged commit e9b1cea into wolfSSL:master Aug 31, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make ByteReverseWords available for big and little endian #3255

Make ByteReverseWords available for big and little endian #3255

tmael commented Aug 26, 2020

dgarske left a comment

dgarske commented Aug 29, 2020

Make ByteReverseWords available for big and little endian #3255

Make ByteReverseWords available for big and little endian #3255

Conversation

tmael commented Aug 26, 2020

dgarske left a comment

Choose a reason for hiding this comment

dgarske commented Aug 29, 2020