OpenVPN changes #2825
Merged
OpenVPN changes #2825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julek-wolfssl
force-pushed
the
self-include-options
branch
from
7d344e3
to
cb45a0f
Compare
SparkiDev
requested changes
Mar 2, 2020
Include <wolfssl/options.h> in settings.h for OpenVPN Additional API fixes
julek-wolfssl
force-pushed
the
self-include-options
branch
from
cb45a0f
to
480f2d6
Compare
julek-wolfssl
added a commit
to julek-wolfssl/openvpn
that referenced
this pull request
Apr 3, 2020
This patch adds support for wolfSSL in OpenVPN. Support is added by using wolfSSL's OpenSSL compatibility layer. Function calls are left unchanged and instead the headers now point to wolfSSL headers and OpenVPN is linked to the wolfSSL library binary. As requested by OpenVPN maintainers, this patch does not include wolfssl/options.h on its own. By defining the macro ENABLE_INCLUDE_OPTIONS_H_FOR_OPENVPN in the configure script wolfSSL will include wolfssl/options.h on its own (change added in wolfSSL/wolfssl#2825). The patch adds an option '--disable-wolfssl-options-h' in case the user would like to supply their own settings file. wolfSSL: Support added in: wolfSSL/wolfssl#2503 ``` git clone https://github.com/wolfSSL/wolfssl.git cd wolfssl ./autogen.sh ./configure --enable-openvpn make sudo make install ``` OpenVPN: ``` autoreconf -i -v -f ./configure --with-crypto-library=wolfssl make make check sudo make install ``` Signed-off-by: Juliusz Sosinowicz <juliusz@wolfssl.com>
julek-wolfssl
force-pushed
the
self-include-options
branch
from
480f2d6
to
55c5415
Compare
julek-wolfssl
added a commit
to julek-wolfssl/openvpn
that referenced
this pull request
Apr 4, 2020
This patch adds support for wolfSSL in OpenVPN. Support is added by using wolfSSL's OpenSSL compatibility layer. Function calls are left unchanged and instead the headers now point to wolfSSL headers and OpenVPN is linked to the wolfSSL library binary. As requested by OpenVPN maintainers, this patch does not include wolfssl/options.h on its own. By defining the macro ENABLE_INCLUDE_OPTIONS_H_FOR_OPENVPN in the configure script wolfSSL will include wolfssl/options.h on its own (change added in wolfSSL/wolfssl#2825). The patch adds an option '--disable-wolfssl-options-h' in case the user would like to supply their own settings file. wolfSSL: Support added in: wolfSSL/wolfssl#2503 ``` git clone https://github.com/wolfSSL/wolfssl.git cd wolfssl ./autogen.sh ./configure --enable-openvpn make sudo make install ``` OpenVPN: ``` autoreconf -i -v -f ./configure --with-crypto-library=wolfssl make make check sudo make install ``` Signed-off-by: Juliusz Sosinowicz <juliusz@wolfssl.com>
julek-wolfssl
added a commit
to julek-wolfssl/openvpn
that referenced
this pull request
Apr 6, 2020
This patch adds support for wolfSSL in OpenVPN. Support is added by using wolfSSL's OpenSSL compatibility layer. Function calls are left unchanged and instead the headers now point to wolfSSL headers and OpenVPN is linked to the wolfSSL library binary. As requested by OpenVPN maintainers, this patch does not include wolfssl/options.h on its own. By defining the macro EXTERNAL_OPTS_OPENVPN in the configure script wolfSSL will include wolfssl/options.h on its own (change added in wolfSSL/wolfssl#2825). The patch adds an option '--disable-wolfssl-options-h' in case the user would like to supply their own settings file. wolfSSL: Support added in: wolfSSL/wolfssl#2503 ``` git clone https://github.com/wolfSSL/wolfssl.git cd wolfssl ./autogen.sh ./configure --enable-openvpn make sudo make install ``` OpenVPN: ``` autoreconf -i -v -f ./configure --with-crypto-library=wolfssl make make check sudo make install ``` Signed-off-by: Juliusz Sosinowicz <juliusz@wolfssl.com>
julek-wolfssl
force-pushed
the
self-include-options
branch
from
55c5415
to
06f2322
Compare
SparkiDev
approved these changes
Apr 6, 2020
julek-wolfssl
added a commit
to julek-wolfssl/openvpn
that referenced
this pull request
Apr 10, 2020
This patch adds support for wolfSSL in OpenVPN. Support is added by using wolfSSL's OpenSSL compatibility layer. Function calls are left unchanged and instead the headers now point to wolfSSL headers and OpenVPN is linked to the wolfSSL library binary. As requested by OpenVPN maintainers, this patch does not include wolfssl/options.h on its own. By defining the macro EXTERNAL_OPTS_OPENVPN in the configure script wolfSSL will include wolfssl/options.h on its own (change added in wolfSSL/wolfssl#2825). The patch adds an option '--disable-wolfssl-options-h' in case the user would like to supply their own settings file for wolfSSL. wolfSSL: Support added in: wolfSSL/wolfssl#2503 ``` git clone https://github.com/wolfSSL/wolfssl.git cd wolfssl ./autogen.sh ./configure --enable-openvpn make sudo make install ``` OpenVPN: ``` autoreconf -i -v -f ./configure --with-crypto-library=wolfssl make make check sudo make install ``` Signed-off-by: Juliusz Sosinowicz <juliusz@wolfssl.com>
toddouska
reviewed
Apr 13, 2020
| @@ -46222,7 +46233,7 @@ unsigned long wolfSSL_ERR_peek_error_line_data(const char **file, int *line, | |||
| ret = -ret; | |||
| } | |||
|
|
|||
| if (ret == ASN_NO_PEM_HEADER) | |||
| if (ret == -ASN_NO_PEM_HEADER) | |||
There was a problem hiding this comment.
Is this always correct, a - error? Shouldn't we convert the error before checking?
There was a problem hiding this comment.
The if case above this one takes the absolute values and so does WOLFSSL_ERROR_LINE in line 407: error = error - (2 * error); /* get absolute value */.
Checking this is important because in wolfSSL_PEM_read_bio_X509 we push ASN_NO_PEM_HEADER as an error to mean that the WOLFSSL_BIO is empty. This error is used in src/openvpn/ssl_openssl.c in tls_ctx_add_extra_certs.
toddouska
approved these changes
Apr 13, 2020
julek-wolfssl
added a commit
to julek-wolfssl/openvpn
that referenced
this pull request
Apr 14, 2020
This patch adds support for wolfSSL in OpenVPN. Support is added by using wolfSSL's OpenSSL compatibility layer. Function calls are left unchanged and instead the headers now point to wolfSSL headers and OpenVPN is linked to the wolfSSL library binary. As requested by OpenVPN maintainers, this patch does not include wolfssl/options.h on its own. By defining the macro EXTERNAL_OPTS_OPENVPN in the configure script wolfSSL will include wolfssl/options.h on its own (change added in wolfSSL/wolfssl#2825). The patch adds an option '--disable-wolfssl-options-h' in case the user would like to supply their own settings file for wolfSSL. wolfSSL: Support added in: wolfSSL/wolfssl#2503 ``` git clone https://github.com/wolfSSL/wolfssl.git cd wolfssl ./autogen.sh ./configure --enable-openvpn make sudo make install ``` OpenVPN: ``` autoreconf -i -v -f ./configure --with-crypto-library=wolfssl make make check sudo make install ``` Signed-off-by: Juliusz Sosinowicz <juliusz@wolfssl.com>
julek-wolfssl
added a commit
to julek-wolfssl/openvpn
that referenced
this pull request
Apr 16, 2020
This patch adds support for wolfSSL in OpenVPN. Support is added by using wolfSSL's OpenSSL compatibility layer. Function calls are left unchanged and instead the OpenSSL includes point to wolfSSL headers and OpenVPN is linked against the wolfSSL library. As requested by OpenVPN maintainers, this patch does not include wolfssl/options.h on its own. By defining the macro EXTERNAL_OPTS_OPENVPN in the configure script wolfSSL will include wolfssl/options.h on its own (change added in wolfSSL/wolfssl#2825). The patch adds an option '--disable-wolfssl-options-h' in case the user would like to supply their own settings file for wolfSSL. wolfSSL: Support added in: wolfSSL/wolfssl#2503 ``` git clone https://github.com/wolfSSL/wolfssl.git cd wolfssl ./autogen.sh ./configure --enable-openvpn make sudo make install ``` OpenVPN: ``` autoreconf -i -v -f ./configure --with-crypto-library=wolfssl make make check sudo make install ``` Signed-off-by: Juliusz Sosinowicz <juliusz@wolfssl.com>
julek-wolfssl
added a commit
to julek-wolfssl/openvpn
that referenced
this pull request
Apr 29, 2020
This patch adds support for wolfSSL in OpenVPN. Support is added by using wolfSSL's OpenSSL compatibility layer. Function calls are left unchanged and instead the OpenSSL includes point to wolfSSL headers and OpenVPN is linked against the wolfSSL library. As requested by OpenVPN maintainers, this patch does not include wolfssl/options.h on its own. By defining the macro EXTERNAL_OPTS_OPENVPN in the configure script wolfSSL will include wolfssl/options.h on its own (change added in wolfSSL/wolfssl#2825). The patch adds an option `--disable-wolfssl-options-h` in case the user would like to supply their own settings file for wolfSSL. wolfSSL: Support added in: wolfSSL/wolfssl#2503 ``` git clone https://github.com/wolfSSL/wolfssl.git cd wolfssl ./autogen.sh ./configure --enable-openvpn make sudo make install ``` OpenVPN: ``` autoreconf -i -v -f ./configure --with-crypto-library=wolfssl make make check sudo make install ``` Signed-off-by: Juliusz Sosinowicz <juliusz@wolfssl.com>
julek-wolfssl
added a commit
to julek-wolfssl/openvpn
that referenced
this pull request
Nov 19, 2020
This patch adds support for wolfSSL in OpenVPN. Support is added by using wolfSSL's OpenSSL compatibility layer. Function calls are left unchanged and instead the OpenSSL includes point to wolfSSL headers and OpenVPN is linked against the wolfSSL library. The wolfSSL installation directory is detected using pkg-config. As requested by OpenVPN maintainers, this patch does not include wolfssl/options.h on its own. By defining the macro EXTERNAL_OPTS_OPENVPN in the configure script wolfSSL will include wolfssl/options.h on its own (change added in wolfSSL/wolfssl#2825). The patch adds an option `--disable-wolfssl-options-h` in case the user would like to supply their own settings file for wolfSSL. wolfSSL: Support added in: wolfSSL/wolfssl#2503 ``` git clone https://github.com/wolfSSL/wolfssl.git cd wolfssl ./autogen.sh ./configure --enable-openvpn make sudo make install ``` OpenVPN: ``` autoreconf -i -v -f ./configure --with-crypto-library=wolfssl make make check sudo make install ``` Signed-off-by: Juliusz Sosinowicz <juliusz@wolfssl.com>
julek-wolfssl
added a commit
to julek-wolfssl/openvpn
that referenced
this pull request
Jan 27, 2021
This patch adds support for wolfSSL in OpenVPN. Support is added by using wolfSSL's OpenSSL compatibility layer. Function calls are left unchanged and instead the OpenSSL includes point to wolfSSL headers and OpenVPN is linked against the wolfSSL library. The wolfSSL installation directory is detected using pkg-config. As requested by OpenVPN maintainers, this patch does not include wolfssl/options.h on its own. By defining the macro EXTERNAL_OPTS_OPENVPN in the configure script wolfSSL will include wolfssl/options.h on its own (change added in wolfSSL/wolfssl#2825). The patch adds an option `--disable-wolfssl-options-h` in case the user would like to supply their own settings file for wolfSSL. wolfSSL: Support added in: wolfSSL/wolfssl#2503 ``` git clone https://github.com/wolfSSL/wolfssl.git cd wolfssl ./autogen.sh ./configure --enable-openvpn make sudo make install ``` OpenVPN: ``` autoreconf -i -v -f ./configure --with-crypto-library=wolfssl make make check sudo make install ``` Signed-off-by: Juliusz Sosinowicz <juliusz@wolfssl.com>
julek-wolfssl
added a commit
to julek-wolfssl/openvpn
that referenced
this pull request
Mar 12, 2021
This patch adds support for wolfSSL in OpenVPN. Support is added by using wolfSSL's OpenSSL compatibility layer. Function calls are left unchanged and instead the OpenSSL includes point to wolfSSL headers and OpenVPN is linked against the wolfSSL library. The wolfSSL installation directory is detected using pkg-config. As requested by OpenVPN maintainers, this patch does not include wolfssl/options.h on its own. By defining the macro EXTERNAL_OPTS_OPENVPN in the configure script wolfSSL will include wolfssl/options.h on its own (change added in wolfSSL/wolfssl#2825). The patch adds an option `--disable-wolfssl-options-h` in case the user would like to supply their own settings file for wolfSSL. wolfSSL: Support added in: wolfSSL/wolfssl#2503 ``` git clone https://github.com/wolfSSL/wolfssl.git cd wolfssl ./autogen.sh ./configure --enable-openvpn make sudo make install ``` OpenVPN: ``` autoreconf -i -v -f ./configure --with-crypto-library=wolfssl make make check sudo make install ``` Signed-off-by: Juliusz Sosinowicz <juliusz@wolfssl.com>
julek-wolfssl
added a commit
to julek-wolfssl/openvpn
that referenced
this pull request
Mar 17, 2021
This patch adds support for wolfSSL in OpenVPN. Support is added by using wolfSSL's OpenSSL compatibility layer. Function calls are left unchanged and instead the OpenSSL includes point to wolfSSL headers and OpenVPN is linked against the wolfSSL library. The wolfSSL installation directory is detected using pkg-config. As requested by OpenVPN maintainers, this patch does not include wolfssl/options.h on its own. By defining the macro EXTERNAL_OPTS_OPENVPN in the configure script wolfSSL will include wolfssl/options.h on its own (change added in wolfSSL/wolfssl#2825). The patch adds an option `--disable-wolfssl-options-h` in case the user would like to supply their own settings file for wolfSSL. wolfSSL: Support added in: wolfSSL/wolfssl#2503 ``` git clone https://github.com/wolfSSL/wolfssl.git cd wolfssl ./autogen.sh ./configure --enable-openvpn make sudo make install ``` OpenVPN: ``` autoreconf -i -v -f ./configure --with-crypto-library=wolfssl make make check sudo make install ``` Signed-off-by: Juliusz Sosinowicz <juliusz@wolfssl.com>
cron2
pushed a commit
to OpenVPN/openvpn
that referenced
this pull request
Mar 18, 2021
This patch adds support for wolfSSL in OpenVPN. Support is added by using wolfSSL's OpenSSL compatibility layer. Function calls are left unchanged and instead the OpenSSL includes point to wolfSSL headers and OpenVPN is linked against the wolfSSL library. The wolfSSL installation directory is detected using pkg-config. As requested by OpenVPN maintainers, this patch does not include wolfssl/options.h on its own. By defining the macro EXTERNAL_OPTS_OPENVPN in the configure script wolfSSL will include wolfssl/options.h on its own (change added in wolfSSL/wolfssl#2825). The patch adds an option `--disable-wolfssl-options-h` in case the user would like to supply their own settings file for wolfSSL. wolfSSL: Support added in: wolfSSL/wolfssl#2503 ``` git clone https://github.com/wolfSSL/wolfssl.git cd wolfssl ./autogen.sh ./configure --enable-openvpn make sudo make install ``` OpenVPN: ``` autoreconf -i -v -f ./configure --with-crypto-library=wolfssl make make check sudo make install ``` Signed-off-by: Juliusz Sosinowicz <juliusz@wolfssl.com> Acked-by: Arne Schwabe <arne@rfc2549.org> Message-Id: <20210317181153.83716-1-juliusz@wolfssl.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg21686.html Signed-off-by: Gert Doering <gert@greenie.muc.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include <wolfssl/options.h> in settings.h for OpenVPN
Additional API fixes